1916680 - Rules view bezier swatch toggle doesn't adapt to High Contrast Mode

Status: RESOLVED FIXED

(DevTools :: Inspector: Rules, defect, P2)

Description

[Nicolas Chevobbe [:nchevobbe]]

Attachment: bezier swatch icon in High Contrast Mode

The icon doesn't have a border (the regular theme only sets a box shadow), and its color doesn't adapt to HCM

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

Triaging as S2 because UI doesn't adapt to HCM

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The severity field for this bug is set to S3. However, the accessibility severity is higher, .
:jdescottes, could you consider increasing the severity?

For more information, please visit BugBot documentation.

Comment 3

[Julian Descottes [:jdescottes]]

For those bugs it's fine to have a different severity than the accessibility severity

Comment 4

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1916680 - [devtools] Add outline to inspector swatch buttons. r=#devtools.

The swatches have a box-shadow as subtle borders in regular mode.
Those are ignored in HCM, so we replace them with an outline.

Comment 5

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1916680 - [devtools] Adapt cubic bezier swatch in High Contrast Mode. r=#devtools.

Add context-fill and context-stroke to the svg file, and style those in CSS.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0e0ee8a704c4
[devtools] Add outline to inspector swatch buttons. r=devtools-reviewers,jdescottes.
https://hg.mozilla.org/integration/autoland/rev/d16257430efc
[devtools] Adapt cubic bezier swatch in High Contrast Mode. r=devtools-reviewers,jdescottes.

Comment 7

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/0e0ee8a704c4
https://hg.mozilla.org/mozilla-central/rev/d16257430efc