1916682 - Bezier tooltip curve editor does not adapt to High Contrast Mode

Status: RESOLVED FIXED

(DevTools :: Inspector: Rules, defect, P2)

Description

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bezier curve editor in High Contrast Mode

See screenshot:

• the handles don't have a border
• at the bottom, there should be a line behind the little circle that moves
• the circle itself should have a border
• the background should be a grid
• the curve itself maybe need a system color ?

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The severity field for this bug is set to S3. However, the accessibility severity is higher, .
:jdescottes, could you consider increasing the severity?

For more information, please visit BugBot documentation.

Comment 2

[Julian Descottes [:jdescottes]]

For those bugs it's fine to have a different severity than the accessibility severity

Comment 3

[Anna Yeddi [:ayeddi] ⛔ Out of office until November 12 ⛔]

Adding a keyword no-plan-to-ship as an ad-hoc flag here. This keyword was meant to exclude specific bugs from the general access-S2 tracking when there are no plans to ship the affected feature. However, we do plan to address and ship this and other HCM-related devtools bugs, which are part of a larger project. This Dev Tools High Contrast Mode support project, tracked by the meta bug 1590215, is ongoing and is tracked by the Dev Tools team separately.

Comment 4

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1916682 - [devtools] Refactor cubic bezier widget layout. r=#devtools.

Use a grid for the tooltip, driven by CSS variables that we retrieve in JS
to compute the canvas size.
Retrieve CSS variables for drawing in the canvas, and draw the diagonal
between the control points in the canvas too (instead as a background gradient).
Don't overlap the canvas and the animation easing preview as it could be
hard to discernate in High Contrast Mode.

Comment 5

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1916682 - [devtools] Adapt cubic bezier curve widget in High Contrast Mode. r=#devtools.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/185f7ddba4e1
[devtools] Refactor cubic bezier widget layout. r=devtools-reviewers,ochameau.
https://hg.mozilla.org/integration/autoland/rev/88101123c872
[devtools] Adapt cubic bezier curve widget in High Contrast Mode. r=devtools-reviewers,ochameau.

Comment 7

[Sandor Molnar[:smolnar]]

Backed out for causing dt failures @ browser_cubic-bezier-01.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/29ed6e40f66d4d3a568cdc0d46e05fced24e5fe3

Push with failures

Failure log -> TEST-UNEXPECTED-FAIL | devtools/client/shared/test/browser_cubic-bezier-01.js | Uncaught exception in test bound - at resource://devtools/client/shared/widgets/CubicBezierWidget.js:323 - TypeError: can't access property "groups", dimensionRegex.exec(...) is null

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d000aaf8e80e
[devtools] Refactor cubic bezier widget layout. r=devtools-reviewers,ochameau.
https://hg.mozilla.org/integration/autoland/rev/2220e252fbc8
[devtools] Adapt cubic bezier curve widget in High Contrast Mode. r=devtools-reviewers,ochameau.

Comment 9

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/d000aaf8e80e
https://hg.mozilla.org/mozilla-central/rev/2220e252fbc8