1916693 - Linear editor does not adapt to High Contrast Mode

Status: RESOLVED FIXED

(DevTools :: Inspector: Rules, defect, P2)

Description

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Linear editor

See screenshot:

• at the bottom, there should be a line behind the little circle that moves
• the circle itself should have a border
• the background grid doesn't have a contrasted enough color
• the linear line itself may use a system color ?

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The severity field for this bug is set to S3. However, the accessibility severity is higher, .
:jdescottes, could you consider increasing the severity?

For more information, please visit BugBot documentation.

Comment 2

[Julian Descottes [:jdescottes]]

For those bugs it's fine to have a different severity than the accessibility severity

Comment 3

[Anna Yeddi [:ayeddi] ⛔ Out of office until November 12 ⛔]

Adding a keyword no-plan-to-ship as an ad-hoc flag here. This keyword was meant to exclude specific bugs from the general access-S2 tracking when there are no plans to ship the affected feature. However, we do plan to address and ship this and other HCM-related devtools bugs, which are part of a larger project. This Dev Tools High Contrast Mode support project, tracked by the meta bug 1590215, is ongoing and is tracked by the Dev Tools team separately.

Comment 4

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1916693 - [devtools] Use/rename variables for shared colors between cubic bezier and linear widgets. r=#devtools.

Comment 5

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1916693 - [devtools] Adapt linear easing widget in High Contrast Mode. r=#devtools

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/300625eeb1ad
[devtools] Use/rename variables for shared colors between cubic bezier and linear widgets. r=devtools-reviewers,ochameau.
https://hg.mozilla.org/integration/autoland/rev/a7f8831aaae7
[devtools] Adapt linear easing widget in High Contrast Mode. r=devtools-reviewers,ochameau

Comment 7

[Sandor Molnar[:smolnar]]

Backed out for causing dt failures @ browser_cubic-bezier-01.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/29ed6e40f66d4d3a568cdc0d46e05fced24e5fe3

Push with failures

Failure log -> TEST-UNEXPECTED-FAIL | devtools/client/shared/test/browser_cubic-bezier-01.js | Uncaught exception in test bound - at resource://devtools/client/shared/widgets/CubicBezierWidget.js:323 - TypeError: can't access property "groups", dimensionRegex.exec(...) is null

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e614cd675231
[devtools] Use/rename variables for shared colors between cubic bezier and linear widgets. r=devtools-reviewers,ochameau.
https://hg.mozilla.org/integration/autoland/rev/1bf1b61b2c39
[devtools] Adapt linear easing widget in High Contrast Mode. r=devtools-reviewers,ochameau

Comment 9

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/e614cd675231
https://hg.mozilla.org/mozilla-central/rev/1bf1b61b2c39