ScreenOrientation.lock api not implemented
Categories
(Fenix :: Browser Engine, enhancement)
Tracking
(Not tracked)
People
(Reporter: elidoset, Unassigned)
Details
Steps to reproduce:
The ScreenOrientation.lock and ScreenOrientation.unlock methods are not implemented in Fenix as of the latest version. Using them throws a NotImplemented exception.
Actual results:
So if I understand correctly, the API was added to GeckoView back in 2021 (see bug 1697647), providing a ScreenOrientationDelegate to be implemented by the user. However Fenix never implements the API.
Expected results:
Fenix should include an implementation of the ScreenOrientationDelegate implementing the lock and unlock feature, using something like Activity.setRequestedOrientation(int), as it is done in the test case provided in the bug 1697647 (unlocking can also be achieved by providing ActivityInfo.SCREEN_ORIENTATION_UNSPECIFIED I presume).
I'm interested in doing the implementation work myself as an exercise if that's okay with you.
|
Reporter | |
Comment 1•4 months ago
|
||
Sorry for the inconvenience, I tried compiling the nightly version which to my surprise worked, and I then found out that the feature was already implemented, simply not enabled on the main releases, seemingly because of bug 1744125 ? Will close the issue as it does appear that it's not useful.
Description
•