1916727 - Perma /html/semantics/scripting-1/the-script-element/json-module/charset-2.html | SyntaxError: import assertions are not currently supported when Gecko 132 merges to beta on 2024-09-30

Status: VERIFIED FIXED

(Core :: DOM: Events, defect)

Description

[Noemi Erli[:noemi_erli]]

Central-as-beta simulation:
How to run these simulations:
Failure log

[task 2024-09-04T13:00:22.850Z] 13:00:22     INFO - TEST-START | /html/semantics/scripting-1/the-script-element/json-module/charset-2.html
[task 2024-09-04T13:00:22.862Z] 13:00:22     INFO - Setting pref javascript.options.experimental.import_attributes to true
[task 2024-09-04T13:00:23.168Z] 13:00:23     INFO - Closing window 0fb14a64-ad23-4493-8f57-d4b797ddc260
[task 2024-09-04T13:00:23.371Z] 13:00:23     INFO - PID 1076 | JavaScript error: http://web-platform.test:8000/html/semantics/scripting-1/the-script-element/json-module/charset-2.html, line 8: SyntaxError: import assertions are not currently supported
[task 2024-09-04T13:00:23.371Z] 13:00:23     INFO - PID 1076 | JavaScript error: http://web-platform.test:8000/html/semantics/scripting-1/the-script-element/json-module/charset-2.html, line 14: SyntaxError: import assertions are not currently supported
[task 2024-09-04T13:00:23.419Z] 13:00:23     INFO - TEST-UNEXPECTED-ERROR | /html/semantics/scripting-1/the-script-element/json-module/charset-2.html | SyntaxError: import assertions are not currently supported
[task 2024-09-04T13:00:23.419Z] 13:00:23     INFO - http://web-platform.test:8000/html/semantics/scripting-1/the-script-element/json-module/charset-2.html:14:121
[task 2024-09-04T13:00:23.419Z] 13:00:23     INFO - TEST-INFO took 580ms

Comment 1

[BugBot [:suhaib / :marco]]

Set release status flags based on info from the regressing bug 1916104

Comment 2

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

After this line in StaticPrefs.yaml, enabling to set the pref after startup similar to this one should be needed.

Jonatan, could you take care of this failure?

Comment 3

[Jonatan Klemets [:jon4t4n]]

Ops, my bad. I forgot that this pref is nightly only when I updated the WPT metadata. I am traveling for the rest of the week, so I won't be able to submit a patch before early next week. So, in case this needs to be fixed ASAP, someone else needs to pick this up.

I think we need a release_or_beta check here to only set this flag in nightly:
https://searchfox.org/mozilla-central/rev/cc01f11adfacca9cd44a75fd140d2fdd8f9a48d4/testing/web-platform/meta/html/semantics/scripting-1/the-script-element/json-module/__dir__.ini#1

We also need to update the test expectations for all tests here: testing/web-platform/tests/HTML/semantics/scripting-1/the-script-element/json-module/. So that we expect failures in beta and release builds.

Comment 4

[Dan Minor [:dminor]]

It looks like we have until 30 september to fix this, so there's time, but if you'd prefer me to have a look a this, please let me know.

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Attachment: Bug 1916727 - let import_attributes preference be changed after startup. r=dminor

Bug 1877792 sets javascript.options.experimental.import_attributes for a wpt
test which gets applied after startup. Change the preference to support this
need.

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

A patch with the change suggested in comment 2 is available and will be tested by the code sheriffs tomorrow.

In the past (e.g. :bz), wpt expectations were set based on the default behavior of the branch, e.g. with feature enabled in central/Nightly as passing, failing for release and beta. Nowadays explicitly enabling the feature preference and setting the test expectations based on that is the default behavior. I did not get a definitive answer if this affects wpt overview sites which show features as implemented/shipping or not.

Comment 7

[Cristina Horotan [:chorotan]]

The patch is not working, still failing on today's beta sim with the patch imported.

Comment 8

[Intermittent Failures Robot]

12 failures in 3668 pushes (0.003 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• try: 12

Platform and build breakdown:

• linux1804-32-shippable-qr: 2
  • opt: 2
• linux1804-64-devedition-qr: 2
  • opt: 2
• android-em-7-0-x86_64-shippable-lite-qr: 1
  • opt: 1
• macosx1015-64-devedition-qr: 1
  • opt: 1
• windows11-64-2009-qr: 1
  • debug: 1
• linux1804-64-asan-qr: 1
  • opt: 1
• windows11-32-2009-qr: 1
  • debug: 1
• macosx1015-64-qr: 1
  • debug: 1
• linux1804-64-qr: 1
  • debug: 1
• linux1804-64-tsan-qr: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1916727&startday=2024-09-02&endday=2024-09-08&tree=all

Comment 9

[Jonatan Klemets [:jon4t4n]]

Attachment: Bug 1916727 - Only set import attributes pref if not release or beta r=#spidermonkey-reviewers

Comment 10

[Jonatan Klemets [:jon4t4n]]

Attachment: Bug 1916727 - Update WPT test expectations for JSON modules r=#spidermonkey-reviewers

Comment 11

[Jonatan Klemets [:jon4t4n]]

This patch stack should fix the beta sim failures.

Comment 12

[Sandor Molnar[:smolnar]]

Patch is working in latest beta simulation

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3aab30167c79
Only set import attributes pref if not release or beta r=spidermonkey-reviewers,mgaudet
https://hg.mozilla.org/integration/autoland/rev/f51b5125467a
Update WPT test expectations for JSON modules r=spidermonkey-reviewers,mgaudet

Comment 14

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/3aab30167c79
https://hg.mozilla.org/mozilla-central/rev/f51b5125467a

Comment 15

[Norisz Fay [:noriszfay]]

Verified fixed in today's central as beta sim

Comment 16

[Intermittent Failures Robot]

1 failures in 4448 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• try: 1

Platform and build breakdown:

• linux1804-64-devedition-qr: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1916727&startday=2024-09-09&endday=2024-09-15&tree=all