1916804 - Make Content Analysis for DND use getURIForBrowsingContext

Status: RESOLVED FIXED

(Firefox :: Data Loss Prevention, defect)

Description

[David Parks [:handyman]]

In bug 1910452, DND is using the URI for the target frame. Bug 1914068 will introduce GetURIForBrowsingContext (when it lands) -- that should be used instead.

Comment 1

[David Parks [:handyman]]

Attachment: Bug 1916804: Make content analysis DND use getURIForDropEvent r=#dlp-reviewers!

getURIForDropEvent delegates to getURIForBrowsingContext -- the ground truth for
CA URIs.

This also adds a check that getURIForDropEvent is correctly called in CA tests.
We do not yet test that it returns the right value -- that is future work.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/18562d27f660
Make content analysis DND use getURIForDropEvent r=dlp-reviewers,reusable-components-reviewers,gstoll,mstriemer

Comment 3

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/18562d27f660

Comment 4

[Greg Stoll :gstoll]

Attachment: Bug 1916804: Make content analysis DND use getURIForDropEvent r=#dlp-reviewers!

getURIForDropEvent delegates to getURIForBrowsingContext -- the ground truth for
CA URIs.

This also adds a check that getURIForDropEvent is correctly called in CA tests.
We do not yet test that it returns the right value -- that is future work.

Original Revision: https://phabricator.services.mozilla.com/D222192

Comment 5

[Phabricator Automation]

esr128 Uplift Approval Request

• User impact if declined: DLP URL to check will be wrong if drag/drop inside an iframe
• Code covered by automated testing: yes
• Fix verified in Nightly: yes
• Needs manual QE test: no
• Steps to reproduce for manual QE testing: n/a
• Risk associated with taking this patch: low
• Explanation of risk level: only affects DLP
• String changes made/needed: no
• Is Android affected?: no

Comment 6

[Greg Stoll :gstoll]

Attachment: Bug 1916804: Make content analysis DND use getURIForDropEvent

getURIForDropEvent delegates to getURIForBrowsingContext -- the ground truth for
CA URIs.

This also adds a check that getURIForDropEvent is correctly called in CA tests.
We do not yet test that it returns the right value -- that is future work.

Original Revision: https://phabricator.services.mozilla.com/D222192

Comment 7

[Phabricator Automation]

esr128 Uplift Approval Request

• User impact if declined: DLP URL to check will be wrong if drag/drop inside an iframe
• Code covered by automated testing: yes
• Fix verified in Nightly: yes
• Needs manual QE test: no
• Steps to reproduce for manual QE testing: n/a
• Risk associated with taking this patch: low
• Explanation of risk level: only affects DLP
• String changes made/needed: no
• Is Android affected?: no

Comment 8

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-esr128/rev/1ae6eddb9ffb