1916884 - Restore Last Closed Tab doesn't restore tab in another window if there are no tabs to restore in the current window

Status: NEW

(Firefox :: Session Restore, defect)

Description

[tabmix.onemen]

(In reply to :Gijs from bug 1819675 - comment #40)

All I want Is to point for inconsistency between reopening last closed tab/s with shortcut ctrl-shift-t/cmd-shift-t and the visibility of closed tabs in Recently Closed Tabs.

When window A have no closed tabs, but Window B have closed tabs, in both window Recently Closed Tabs will show closed tabs from window B.
but using ctrl-shift-t/cmd-shift-t in Window A will do nothing.

1. clear all recent history in window A (so previous session's tabs aren't in closed tabs)
2. open new window B
3. open example.com in window B
4. open about:config in window B
5. close example.com

Now both window A and window B have one closed tab visible in Recently Closed Tabs
6. ctrl-shift-t/cmd-shift-t - in window A will do nothing.
7. ctrl-shift-t/cmd-shift-t - in window B will do nothing reopen last closed tab.

I find this behavior to be unexpected.
I expects that when browser.sessionstore.closedTabsFromAllWindows is on ctrl-shift-t/cmd-shift-t will undo the last close action in the current session.

lets continue...
8. Now we don't have any closed tabs and Recently Closed Tabs is grayed out in both windows.
9. In window B, close example.com, (window B still have about:config, both windows have Recently Closed Tabs visible)
10. closed window B. (window A, have Recently Closed Tabs and Recently Closed Windows enabled)
11. ctrl-shift-t/cmd-shift-t in window A will restore window B.

In summery, there is different behavior for ctrl-shift-t/cmd-shift-t in window A, in step 6 and step 11.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:peterv, since you are the author of the regressor, bug 181967, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1819675

Comment 3

[:Gijs (he/him)]

Thanks for filing! I'll leave the session store folks to further triage this.

Comment 4

[Sam Foster [:sfoster] (he/him)]

Need-infoing myself to look into this