Open Bug 1916927 Opened 17 days ago Updated 10 days ago

Move field update heuristics from the child process to the parent process

Categories

(Toolkit :: Form Autofill, task, P2)

task

Tracking

()

People

(Reporter: dimi, Assigned: dimi)

References

(Blocks 1 open bug)

Details

(Whiteboard: [fxcm-iframe])

Attachments

(3 files)

Our field identification heuristic contains two phases. The first phase uses various heuristics to determine the field name of a <input> or a <select>[1]. After all fields in a form are identified, we then run heuristics to update field name based on its surrounding field[2] (Phase 2).

Currently both phases are still being run in the child process. We should move the phase2 heuristicss from the child process to the parent process because the surrounding fields might be in a different frame.

[1] https://searchfox.org/mozilla-central/rev/cc01f11adfacca9cd44a75fd140d2fdd8f9a48d4/toolkit/components/formautofill/shared/FormAutofillHeuristics.sys.mjs#604-691
[2] https://searchfox.org/mozilla-central/rev/cc01f11adfacca9cd44a75fd140d2fdd8f9a48d4/toolkit/components/formautofill/shared/FormAutofillHeuristics.sys.mjs#542-551

Blocks: 1876711
Attachment #9423952 - Attachment description: WIP: Bug 1916927 - P1. Move field update heuristics from the child process to the parent process → Bug 1916927 - P1. Move field update heuristics from the child process to the parent process r=#credential-management-reviewers
Attachment #9423953 - Attachment description: WIP: Bug 1916927 - P2. Testcases → Bug 1916927 - P2. Add a testcase and update existing testcases. r=#credential-management-reviewers
Attachment #9423954 - Attachment description: WIP: Bug 1916927 - P3. iOS Change → Bug 1916927 - P3. Make iOS compatible with the architecture change r=#credential-management-reviewers
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: