1917097 - [wpt-sync] Sync PR 47996 - Moved param initialization into finalize() in the Canvas WPT generator

Status: RESOLVED FIXED

(Core :: Graphics: Canvas2D, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 47996 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/47996
Details from upstream follow.

Jean-Philippe Gravel <[e-mail]> wrote:

Moved param initialization into finalize() in the Canvas WPT generator

Before this CL, the variant grid's params was initialized the first
time the grid's params property was used. This implicit
initialization was confusing because it meant we had to first use
params at the exact right time. Using it too soon was a bug (before
the variant's expected_img param is configured for instance).

This CL moves the grid's param creation into the finalize() method,
removing this confusion.

Bug: 364549423
Change-Id: I00bee16fe9f2d8ab13f5b05b49b511ffa642e746
Reviewed-on: https://chromium-review.googlesource.com/5836568
WPT-Export-Revision: 45b13c1ae7758451d59514f929780e2bc41c14fb

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=69c0e65b9311e7be3ca6021553b7fd6cf70004c3

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/661b2ee9b57c
[wpt PR 47996] - Moved param initialization into finalize() in the Canvas WPT generator, a=testonly

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Test result changes from PR not available.

Comment 4

[tszentpeteri]

https://hg.mozilla.org/mozilla-central/rev/661b2ee9b57c