1917138 - Crash in [@ java.lang.RuntimeException: at androidx.coordinatorlayout.widget.DirectedAcyclicGraph.dfs(DirectedAcyclicGraph.java)]

Status: RESOLVED FIXED

(Firefox for Android :: General, defect)

Description

[Roger Yang [:royang]]

Crash report: https://crash-stats.mozilla.org/report/index/6e275eef-aee0-4d33-9156-9fbaf0240905

Top 10 frames:

0  androidx.coordinatorlayout.widget.DirectedAcyclicGraph  dfs  DirectedAcyclicGraph.java:55
1  androidx.coordinatorlayout.widget.DirectedAcyclicGraph  dfs  DirectedAcyclicGraph.java:38
2  androidx.coordinatorlayout.widget.DirectedAcyclicGraph  dfs  DirectedAcyclicGraph.java:38
3  androidx.coordinatorlayout.widget.DirectedAcyclicGraph  dfs  DirectedAcyclicGraph.java:38
4  androidx.coordinatorlayout.widget.CoordinatorLayout  prepareChildren  CoordinatorLayout.java:386
5  androidx.coordinatorlayout.widget.CoordinatorLayout  onMeasure  CoordinatorLayout.java:4
6  android.view.View  measure  View.java:28571
7  androidx.constraintlayout.widget.ConstraintLayout$Measurer  measure  ConstraintLayout.java:540
8  androidx.constraintlayout.core.widgets.ConstraintWidgetContainer  measure  ConstraintWidgetContainer.java:47
9  androidx.constraintlayout.core.widgets.ConstraintWidgetContainer  layout  ConstraintWidgetContainer.java:138

Comment 1

[BugBot [:suhaib / :marco]]

The Bugbug bot thinks this bug should belong to the 'Fenix::Crash Reporting' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[BugBot [:suhaib / :marco]]

The bug is linked to a topcrash signature, which matches the following criterion:

• Top 10 AArch64 and ARM crashes on nightly

For more information, please visit BugBot documentation.

Comment 3

[BugBot [:suhaib / :marco]]

The bug is marked as tracked for firefox132 (nightly). However, the bug still isn't assigned.

:boek, could you please find an assignee for this tracked bug? If you disagree with the tracking decision, please talk with the release managers.

For more information, please visit BugBot documentation.

Comment 4

[Petru-Mugurel Lingurar [:petru]]

Attachment: Bug 1917138 - Avoid a dependencies chain in placing browser screen views r=#android-reviewers

A recent change introduced returning true in DynamicDownloadDialogBehavior's
layoutDependsOn method to signal to the framework that the download finished dialog
depends on the bottom toolbar.
While technically correct given the complexity of the entire layout the download finished
dialog had it's own View depending on it - the snackbar which may show when users would
tap to open a link in a new tab. And in this scenario we would get a crash.

The approach here comes to restore the previous behavior - return false from the
layoutDependsOn method, written exactly as it was before.

Comment 5

[Polly [:polly]]

i have managed to reproduce the crash now:
a) download a large file file1 in the current tab
b) while still downloading, download another file file2 & open link in new tab
c) snackbar appears offering to switch tab to view file2
d) download complete dialog appears for file1 while snackbar for file2 still visible

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ae16a400e3f8
Avoid a dependencies chain in placing browser screen views r=android-reviewers,pollymce

Comment 7

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/ae16a400e3f8