Closed Bug 1917161 Opened 6 months ago Closed 8 days ago

High frequency toolkit/components/translations/tests/browser/browser_about_translations_language_swap.js | single tracking bug

Categories

(Firefox :: Translations, defect, P5)

defect

Tracking

()

RESOLVED FIXED
137 Branch
Tracking Status
firefox-esr128 --- unaffected
firefox135 --- unaffected
firefox136 --- unaffected
firefox137 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: nordzilla)

References

(Regression)

Details

(Keywords: intermittent-failure, intermittent-testcase, regression)

Attachments

(1 file, 1 obsolete file)

Filed by: sstanca [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=473159999&repo=autoland
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/TR4yjSHES0mKDG7l50tsAg/runs/0/artifacts/public/logs/live_backing.log


[task 2024-09-06T04:20:25.385Z] 04:20:25     INFO - TEST-PASS | toolkit/components/translations/tests/browser/browser_about_translations_language_swap.js | The language swap button is disabled - true == true - 
[task 2024-09-06T04:20:25.385Z] 04:20:25     INFO - Resolving 1 mocked downloads for "test-translation-wasm-1"
[task 2024-09-06T04:20:25.386Z] 04:20:25     INFO - Resolving 3 mocked downloads for "test-translation-models-0"
[task 2024-09-06T04:20:25.386Z] 04:20:25     INFO - Buffered messages finished
[task 2024-09-06T04:20:25.387Z] 04:20:25     INFO - TEST-UNEXPECTED-FAIL | toolkit/components/translations/tests/browser/browser_about_translations_language_swap.js | Uncaught exception in test bound test_about_translations_language_swap - translation from en to fr is complete - timed out after 200 tries.
[task 2024-09-06T04:20:25.387Z] 04:20:25     INFO - Leaving test bound test_about_translations_language_swap
[task 2024-09-06T04:20:25.387Z] 04:20:25     INFO - GECKO(6562) | MEMORY STAT | vsize 8141MB | residentFast 326MB | heapAllocated 132MB
[task 2024-09-06T04:20:25.388Z] 04:20:25     INFO - TEST-OK | toolkit/components/translations/tests/browser/browser_about_translations_language_swap.js | took 40042ms
[task 2024-09-06T04:20:25.388Z] 04:20:25     INFO - Not taking screenshot here: see the one that was previously logged
[task 2024-09-06T04:20:25.388Z] 04:20:25     INFO - TEST-UNEXPECTED-FAIL | toolkit/components/translations/tests/browser/browser_about_translations_language_swap.js | Found an unexpected tab at the end of test run: about:translations - 
[task 2024-09-06T04:20:25.388Z] 04:20:25     INFO - checking window state
[task 2024-09-06T04:20:25.389Z] 04:20:25     INFO - TEST-START | toolkit/components/translations/tests/browser/browser_about_translations_translations.js

Hi Nika! This failure started to be frequent since your changes as you can see here , could you please take a look? Thanks.

Recent failure log: https://treeherder.mozilla.org/logviewer?job_id=493986873&repo=autoland&lineNumber=3874

Flags: needinfo?(nika)
Keywords: regression
Regressed by: 1942128
Summary: Intermittent toolkit/components/translations/tests/browser/browser_about_translations_language_swap.js | single tracking bug → High frequency toolkit/components/translations/tests/browser/browser_about_translations_language_swap.js | single tracking bug

Set release status flags based on info from the regressing bug 1942128

I'm guessing this is an intermittent failure which became more common due to timing changes from my changes to how processes are started for translations. I'm not super familiar with how the translations state machine and such work so I don't know what might be causing this failure.

Leaving my ni? but adding one for :nordzilla who might be more familiar with the internals at play here and might be able to point out what is going wrong.

Flags: needinfo?(nika) → needinfo?(enordin)
Flags: needinfo?(nika)

Hey, yeah I will take a look at this.

Thanks for the NI.

Flags: needinfo?(enordin)

Fixes a race condition where the about:translations page may attempt
to rebuild the translator before the active TranslationsEngine is fully
destroyed. This is likely the cause of the high-frequency intermittent
test failure associated with this bug.

Assignee: nobody → enordin
Status: NEW → ASSIGNED

Comment on attachment 9465607 [details]
Bug 1917161 - Fix race in about:translations reacting to shortlist pref r=#translations-reviewers!

Revision D237846 was moved to bug 1946901. Setting attachment 9465607 [details] to obsolete.

Attachment #9465607 - Attachment is obsolete: true

Fixes a race condition where the about:translations language-swap test
was not waiting for the "Translating..." placeholder text before
resolving mocked downloads. I believe this is the cause of the
high-frequency intermittent test failrue associated with this bug.

Pushed by enordin@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/abf440812e07 Ensure about:translations language swap test waits for placeholder r=translations-reviewers,gregtatum
Status: ASSIGNED → RESOLVED
Closed: 8 days ago
Resolution: --- → FIXED
Target Milestone: --- → 137 Branch
Flags: needinfo?(nika)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: