Closed Bug 1917228 Opened 1 year ago Closed 11 months ago

allow X25519 private keys to be exported in JWK

Categories

(Core :: DOM: Web Crypto, enhancement)

Product:
Core
Component:
DOM: Web Crypto
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
132 Branch
Tracking Flags:
Tracking Status
firefox130 --- wontfix
firefox131 --- fixed
firefox132 --- fixed

People

(Reporter: anna.weine, Assigned: anna.weine)

References

Details

Attachments

(2 files)

Bug 1917228 - WebCrypto: X25519 public key should be copied so it can be exported as jwk
48 bytes, text/x-phabricator-request
Details | Review
Bug 1917228 - WebCrypto: X25519 public key should be copied so it can be exported as jwk
48 bytes, text/x-phabricator-request
phab-bot
: approval-mozilla-beta+
Details | Review
No description provided.
Attachment #9423168 - Attachment description: WIP: Bug 1917228 - X25519 public key should be copied to be extracted using jwk → Bug 1917228 - X25519 public key should be copied to be extracted using jwk
Assignee: nobody → anna.weine
Status: NEW → ASSIGNED
Duplicate of this bug: 1918256
Duplicate of this bug: 1918348
Summary: X25519 to be exported in JWK → allow X25519 private to be exported in JWK
Summary: allow X25519 private to be exported in JWK → allow X25519 private keys to be exported in JWK

FYI I've opened a PR to update the WPTs to test export after generate. https://github.com/web-platform-tests/wpt/pull/48144

This is producing a surprising number of duplicates. It might be good to uplift to beta at least.

status-firefox130: --- → affected
status-firefox131: --- → affected
status-firefox132: --- → affected
Attachment #9423168 - Attachment description: Bug 1917228 - X25519 public key should be copied to be extracted using jwk → Bug 1917228 - WebCrypto: X25519 public key should be copied so it can be exported as jwk

Dana, do you have any opinion on whether we should uplift the patch? Thanks

Flags: needinfo?(dkeeler)

Sure - I think it would be great to uplift this. The risk should be quite low.

Flags: needinfo?(dkeeler)
Pushed by nkulatova@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/5736e3f90330 WebCrypto: X25519 public key should be copied so it can be exported as jwk r=keeler
Attachment #9425252 - Flags: approval-mozilla-beta?

:anna the beta patch still needs a filled out uplift form attached to it.

Flags: needinfo?(anna.weine)

beta Uplift Approval Request

  • User impact if declined: minor
  • Code covered by automated testing: no
  • Fix verified in Nightly: yes
  • Needs manual QE test: no
  • Steps to reproduce for manual QE testing: It's enabling a webcryptoapi feature allowing the X25519 keys to be extracted using JWK. The testing would require calling a browser web console, creating an X25519 key and exporting it using JWK. The example is here: https://github.com/diafygi/webcrypto-examples?tab=readme-ov-file#ecdh---exportkey
  • Risk associated with taking this patch: minor
  • Explanation of risk level: the patch enables a feature of exporting the keys that was missing before. Checked in Nightly
  • String changes made/needed: no
  • Is Android affected?: yes

Sorry, I wanted to make sure that the patch going to Nightly will not get broken.

Just filled the form

Flags: needinfo?(anna.weine)
Flags: in-testsuite?

https://hg.mozilla.org/mozilla-central/rev/5736e3f90330

Status: ASSIGNED → RESOLVED
Closed: 11 months ago
status-firefox132: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → 132 Branch
Attachment #9425252 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Duplicate of this bug: 1918354
No longer duplicate of this bug: 1918354
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: