1917229 - [wpt-sync] Sync PR 48013 - Allow :active-view-transition pseudo-classes after ::part().

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 48013 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/48013
Details from upstream follow.

David Baron <[e-mail]> wrote:

Allow :active-view-transition pseudo-classes after ::part().

Based on the discussion in
https://github.com/w3c/csswg-drafts/issues/10806 and also in
https://github.com/w3c/csswg-drafts/issues/10787, I think the conclusion
from #10806 applies to pseudo-classes as well, and I should reverse my
earlier decision to disallow the :active-view-transition pseudo-classes
after ::part(), even though today it is not possible for them to match.

This makes that change behind the CSSPartAllowsMoreSelectorsAfter flag
(status:experimental), which also contains other related changes.

This matches WebKit's current implementation of those pseudo-classes.

Bug: 40623497
Change-Id: I591fe30bb9e6c3a0953df318919f60dd6962d4a1
Reviewed-on: https://chromium-review.googlesource.com/5839421
WPT-Export-Revision: 7d2119f48715ad37984cff212a086e922bee35f7

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=e3eb6b2283fa948fdf7acf5637ddede11c963d07

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 68 subtests

Status Summary

Firefox

OK : 1
PASS: 53
FAIL: 15

Chrome

OK : 1
PASS: 62
FAIL: 6

Safari

OK : 1
PASS: 59
FAIL: 9

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

Firefox-only Failures

• /css/css-shadow-parts/pseudo-classes-after-part.html [wpt.fyi]
  • "::part(mypart):dir(ltr)" should be a valid selector: FAIL
  • "::part(mypart):future" should be a valid selector: FAIL
  • "::part(mypart):lang(en)" should be a valid selector: FAIL
  • "::part(mypart):past" should be a valid selector: FAIL
  • "::part(mypart):picture-in-picture" should be a valid selector: FAIL

New Tests That Don't Pass

• /css/css-shadow-parts/pseudo-classes-after-part.html [wpt.fyi]
  • "::part(mypart):active-view-transition" should be a valid selector: FAIL (Chrome: FAIL, Safari: PASS)
  • "::part(mypart):active-view-transition-type(mytype)" should be a valid selector: FAIL (Chrome: FAIL, Safari: PASS)
  • "::part(mypart):closed" should be a valid selector: FAIL (Chrome: PASS, Safari: FAIL)
  • "::part(mypart):dir(ltr)" should be a valid selector: FAIL (Chrome: PASS, Safari: PASS)
  • "::part(mypart):future" should be a valid selector: FAIL (Chrome: PASS, Safari: PASS)
  • "::part(mypart):lang(en)" should be a valid selector: FAIL (Chrome: PASS, Safari: PASS)
  • "::part(mypart):open" should be a valid selector: FAIL (Chrome: PASS, Safari: FAIL)
  • "::part(mypart):past" should be a valid selector: FAIL (Chrome: PASS, Safari: PASS)
  • "::part(mypart):paused" should be a valid selector: FAIL (Chrome: FAIL, Safari: PASS)
  • "::part(mypart):picture-in-picture" should be a valid selector: FAIL (Chrome: PASS, Safari: PASS)
  • "::part(mypart):playing" should be a valid selector: FAIL (Chrome: FAIL, Safari: PASS)
  • "::part(mypart):xr-overlay" should be a valid selector: FAIL (Chrome: PASS, Safari: FAIL)
  • "::part(mypart):has(:hover)" should be an invalid selector: FAIL (Chrome: PASS, Safari: FAIL)
  • "::part(mypart):is(:first-child)" should be a valid selector: FAIL (Chrome: FAIL, Safari: FAIL)
  • "::part(mypart):where(:first-child)" should be a valid selector: FAIL (Chrome: FAIL, Safari: FAIL)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c38fc2e24461
[wpt PR 48013] - Allow :active-view-transition pseudo-classes after ::part()., a=testonly
https://hg.mozilla.org/integration/autoland/rev/585911dda58e
[wpt PR 48013] - Update wpt metadata, a=testonly

Comment 4

[tszentpeteri]

https://hg.mozilla.org/mozilla-central/rev/c38fc2e24461
https://hg.mozilla.org/mozilla-central/rev/585911dda58e