1917240 - [wpt-sync] Sync PR 48014 - [css-typed-om] Don't crash for unrepresentable shorthands

Status: RESOLVED FIXED

(Core :: DOM: CSS Object Model, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 48014 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/48014
Details from upstream follow.

Anders Hartvoll Ruud <[e-mail]> wrote:

[css-typed-om] Don't crash for unrepresentable shorthands

ComputedStylePropertyMap::SerializationForShorthand for some reason
expects that CSSValueFromComputedStyle can't return nullptr, when in
reality this can easily happen as soon as you have a shorthand
which can't represent the currently held longhands.

We have likely exercised this code for a long time, but ever since
CL:5577948, we begun crashing, since NOTREACHED() is fatal now.

Looking briefly over the spec, it is not defined what to return in
this situation, hence adding a crash test which doesn't make assertions
about the return value.

Fixed: 364443014
Change-Id: I5c6bcc4ef75285194aed2fc0a6b57429655c7610
Reviewed-on: https://chromium-review.googlesource.com/5840236
WPT-Export-Revision: 2c96bfe4713eff4573f494f890746abbfa1694d0

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=652cc836e3ba3abf5f7b9962340f7866cfb75830

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

PASS : 1

Chrome

CRASH: 1

Safari

PASS : 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1ac548ed1499
[wpt PR 48014] - [css-typed-om] Don't crash for unrepresentable shorthands, a=testonly

Comment 4

[tszentpeteri]

https://hg.mozilla.org/mozilla-central/rev/1ac548ed1499