1917288 - Increase expiry date range for network cookie tests

Status: RESOLVED FIXED

(Remote Protocol :: WebDriver BiDi, task, P3)

Description

[Julian Descottes [:jdescottes]]

Follow up to Bug 1916221.

We are currently allowing for a 2s interval to check the cookie expiry date, because Firefox might be slightly adjusting the expiry timestamp based on network.cookie.useServerTime.

We should discuss about potentially setting that preference and/or increasing the interval.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2]]

We cannot just disable it for the cookie tests. It will work fine in our CI but the affected tests are still going to fail upstream where reports are sent to wpt.fyi. This is because metadata files are not evaluated over there.

Comment 2

[Julian Descottes [:jdescottes]]

We decided to just increase the expiry data range.

Comment 3

[f3tch [:f3tchcodes]]

Attachment: Bug 1917288 - Increase expiry date range for network cookie tests. r?jdescottes

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/e5e64c8ed818
https://hg.mozilla.org/integration/autoland/rev/5875be42a5bd
Increase expiry date range for network cookie tests. r=jdescottes,webdriver-reviewers

Comment 5

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/62880 for changes under testing/web-platform/tests

Comment 6

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/5875be42a5bd

Comment 7

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 8

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR was closed without merging

Comment 9

[Henrik Skupin [:whimboo][⌚️UTC+2]]

(In reply to Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org) from comment #8)

Upstream PR was closed without merging

That comment isn't true. The PR was shortly closed and reopened to trigger the GitHub actions again. Finally it was merged.