1917346 - Refactor `TranslationsDropdown` into a top level `Dropdown` composable

Status: VERIFIED FIXED

(Firefox for Android :: Design System and Theming, task)

Description

[Nicholas Poon (redirect NI to [e-mail]) [:Nick]]

Figma
As part of this ticket, also replace the TranslationsDropdown composable, used here

Comment 1

[Nicholas Poon (redirect NI to [e-mail]) [:Nick]]

Attachment: Bug 1917346 - Part 1: Modify `Menu` composable to indicate whether the user can check items on the dropdown menu

Comment 2

[Nicholas Poon (redirect NI to [e-mail]) [:Nick]]

Attachment: Bug 1917346 - Part 2: Refactor `TranslationsDropdown` into a top level `Dropdown` composable

Comment 3

[Nicholas Poon (redirect NI to [e-mail]) [:Nick]]

Attachment: Bug 1917346 - Part 3: Refactor `TranslationsDialogBottomSheet` to use the custom `Dropdown` composable

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/efb3a64422e0
Part 1: Modify `Menu` composable to indicate whether the user can check items on the dropdown menu r=android-reviewers,gl

Comment 5

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/efb3a64422e0

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4047c3780e24
Part 2: Refactor `TranslationsDropdown` into a top level `Dropdown` composable r=android-reviewers,ohall,pollymce

Comment 7

[Nicholas Poon (redirect NI to [e-mail]) [:Nick]]

Hey QA,
Once part 2 merges into mozilla-central, can we check that translations is still working as desired?

In particular, here is the STR:

1. Go to https://en.wikipedia.org/wiki/Canada.
2. Click the 3 dot menu
3. Click on Tools (if menu redesign is enabled)
4. Click on Translate page...
5. Click on both the Translate from and Translate to dropdowns
   i. Check that the padding for the dropdown items is correct. This should be the same regardless of whether items are selected or not. Additionally, check that the touch area fills the entire row when there is no items selected and when there is an item selected.
   ii. Check that the positioning of the dropdown is correct in both landscape and vertical orientations.
   iii. Check that the currently checked item is correct (matches what is shown before you click on the dropdown)
   iv. Check that if the placeholder is currently being shown, no item is selected in the dropdown items
   v. Check that at most 1 dropdown item is selected
   vi. Opening to the selected option and ensuring this was working correctly in TalkBack and that TalkBack works properly in general.
   vii. Check that spamming on the dropdown will not cause flickering and that opening the dropdown will start the animation in 1 place and then open in the same place.
6. Select any Translate from and Translate to language (preferably 2 that you would understand)
7. Click Translate
   i. Check that the page is being translated as expected
8. Click the Translate icon in the toolbar
   i. Check that this dropdown is working as desired (check the same things as 5)
   ii. Check that clicking Show original shows the original
   iii. Check that clicking on a different language in the dropdown and then clicking Translate will translate correctly to the next language.
9. Repeat steps 1-8 with your fenix language set to a different supported translations language and ensure that the dropdown languages (in step 5) are displaying in the different language.

Comment 8

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/4047c3780e24

Comment 9

[Mira Lobontiu (Android QA)]

Verified on the Fenix Nightly 132.0a1 from 9/25 with the following devices:

• Google Pixel 6 (Android 15),
• Samsung Galaxy Tab S9 Ultra (Android 14), and
• Realme GT Master Edition (Android 13).

The following were verified from the three-dot's "Translate page" option, and from the translation icon:

• the padding for the dropdown languages is correct - it is the same regardless of whether languages are selected or not;
• that the touch area fills the entire row when a language is selected or not;
• the positioning of the dropdown is correct in both landscape and portrait;
• the currently checked language is correct (matches what is shown before you tap on the dropdown);
• if the placeholder is currently being displayed, no language is selected in the dropdown languages;
• verified that at most 1 dropdown language is selected;
• verified that opening the selected option and ensuring this was working correctly with TalkBack, and that TalkBack works properly in general;
• spamming on the dropdown will not cause flickering and that opening the dropdown will start the animation in 1 place and then open in the same place;
• the user can select any "Translate from" and "Translate to" language from the dropdown lists;
• verified that when the "Translate" is tapped on, the page is being translated as expected;
• tapping the "Show original", reloads the original page;
• selecting a different language in the dropdown and then tapping "Translate" will translate correctly to the next language;
• repeated all the above scenarios with Fenix language set to a different supported translations language, and ensure that the dropdown languages are displaying in the different language.

Nicholas, I have one question:

• in "Translate from" I have the following languages available: Bosnian, Bulgarian, Catalan, Croatian, Czech, Danish, Dutch, English, Estonian, Finnish, French, German, Greek, Hungarian, Icelandic, Indonesian, Italian, Latvian, Lithuanian, Maltese, Norwegian Bokmal, Norwegian Nynorsk, Persian, Polish, Portuguese, Romanian, Russian, Serbian, Slovak, Slovenian, Swedish, Turkish, Ukranian, Vietnamese, and
• in "Translate to" I only have the following: Bulgarian, Catalan, Croatian, Czech, Danish, Dutch, English, Estonian, Finnish, French, German, Hungarian, Italian, Latvian, Lithuanian, Persian, Polish, Portuguese, Russian, Slovak, Slovenian, Swedish, Turkish, Ukranian.

Is there a reason why the listst are different (I bolded the missing languages)?

Comment 10

[Nicholas Poon (redirect NI to [e-mail]) [:Nick]]

Thanks for verifying the STR!

To answer your question, every translate from to translate to language is a model so I suppose that we don't have models for all languages to all languages yet.

I also asked Olivia on why this may be the case, since she worked on Translations and knows more about this than I do. Here was her reply:

Some languages are still in development and uni-directional. Some of it is we have a better corpus going in one direction than another. Also, I thought this interesting, users who use one direction of a pair don't necessarily use the other (because they know the language). I scanned what she mentioned against the list and it seems to match.