1917493 - Enable quad box shadows on a subset of outset box-shadows

Status: REOPENED

(Core :: Graphics: WebRender, task)

Comment 1

[Glenn Watson [:gw]]

Attachment: Bug 1917493 - Enable quad box shadows on a subset of outset box-shadows

We'll incrementally enable it on a wider range of content once we
resolve the unrelated pre-existing timing-related intermittent failures
that are tickled by these changes.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9b9f5e47c9b0
Enable quad box shadows on a subset of outset box-shadows r=gfx-reviewers,nical

Comment 3

[Sandor Molnar[:smolnar]]

Backed out for causing build bustages

Backout link: https://hg.mozilla.org/integration/autoland/rev/49c8d40d2a31e0c29059693d7c1cc06a9f571921

Push with failures

Failure log -> ERROR - error[E0658]: exclusive range pattern syntax is experimental

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ad3e2b8657ee
Enable quad box shadows on a subset of outset box-shadows r=gfx-reviewers,nical

Comment 5

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/ad3e2b8657ee

Comment 6

[Sandor Molnar[:smolnar]]

Backed out for causing crashes

Backout link: https://hg.mozilla.org/mozilla-central/rev/f47709f0fa48f6c03b361bebe4b2b334053e80ad

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/24e81e2c5ad1
Enable quad box shadows on a subset of outset box-shadows r=gfx-reviewers,nical

Comment 8

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/24e81e2c5ad1

Comment 9

[Iulian Moraru]

Backed out for causing Bug 1922160.

• Push that was backed out

• Backout link

Comment 10

[Mayank Bansal]

I got crash with the latest nightly: https://crash-stats.mozilla.org/report/index/f635f74c-b905-443b-912f-3cbb20241002#tab-bugzilla

Comment 11

[Donal Meehan [:dmeehan]]

(In reply to Mayank Bansal from comment #10)

I got crash with the latest nightly: https://crash-stats.mozilla.org/report/index/f635f74c-b905-443b-912f-3cbb20241002#tab-bugzilla

That crash report is from build 20241001155138 (2024-10-01).
The latest nightly build is 20241002095009 (2024-10-02), this contains the backout mentioned in comment 9

Comment 12

[Mayank Bansal]

(In reply to Donal Meehan [:dmeehan] from comment #11)

(In reply to Mayank Bansal from comment #10)

I got crash with the latest nightly: https://crash-stats.mozilla.org/report/index/f635f74c-b905-443b-912f-3cbb20241002#tab-bugzilla

That crash report is from build 20241001155138 (2024-10-01).
The latest nightly build is 20241002095009 (2024-10-02), this contains the backout mentioned in comment 9

I know that.
When the patch was initially landed, it had got the same crash.
Now that the bug was relanded, I get the same crash. So I am guessing this crash needs to be fixed before the patch lands next.
The webpage where I crash is a banking-type website so I cant create a minimized testcase.

Comment 13

[Alex Finder]

(In reply to Iulian Moraru from comment #9)

Backed out for causing Bug 1922160.

• Push that was backed out

• Backout link

Perfherder has detected a browsertime performance change from push a54af0b7d23a1e96466f4f5a45fa7229b4f88e07.

Improvements:

Ratio	Test	Platform	Options	Absolute values (old vs new)	Performance Profiles
10%	speedometer3 cpuTimePageload	windows11-64-shippable-qr	fission webrender	378.31 -> 340.77	Before/After
7%	speedometer3 TodoMVC-JavaScript-ES5/CompletingAllItems/Async	windows11-64-shippable-qr	fission webrender	2.02 -> 1.88	Before/After
5%	speedometer3 TodoMVC-Svelte-Complex-DOM/DeletingAllItems/Async	windows11-64-shippable-qr	fission webrender	3.63 -> 3.45	Before/After
5%	speedometer3 TodoMVC-Preact-Complex-DOM/DeletingAllItems/Async	windows11-64-shippable-qr	fission webrender	3.36 -> 3.21	Before/After
4%	speedometer3 TodoMVC-Preact-Complex-DOM/DeletingAllItems/total	windows11-64-shippable-qr	fission webrender	4.45 -> 4.29	Before/After
...	...	...	...	...	...
2%	speedometer3 TodoMVC-Angular-Complex-DOM/CompletingAllItems/total	windows11-64-shippable-qr	fission webrender	10.34 -> 10.13	Before/After

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests.

If you need the profiling jobs you can trigger them yourself from treeherder job view or ask a sheriff to do that for you.

You can run these tests on try with ./mach try perf --alert 2325

For more information on performance sheriffing please see our FAQ.

Comment 14

[Alex Finder]

(In reply to Iulian Moraru from comment #9)

Backed out for causing Bug 1922160.

• Push that was backed out

• Backout link

Perfherder has detected a talos performance change from push a54af0b7d23a1e96466f4f5a45fa7229b4f88e07.

Improvements:

Ratio	Test	Platform	Options	Absolute values (old vs new)
10%	tart	windows11-64-shippable-qr	e10s fission stylo webrender-sw	1.94 -> 1.75
5%	tart	windows11-64-shippable-qr	e10s fission stylo webrender-sw	1.93 -> 1.83

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests.

If you need the profiling jobs you can trigger them yourself from treeherder job view or ask a sheriff to do that for you.

You can run these tests on try with ./mach try perf --alert 2395

For more information on performance sheriffing please see our FAQ.