1917543 - The "This Alt text was created automatically" label is displayed for an empty description if we are adding images to a pdf file after an update

Status: VERIFIED FIXED

(Firefox :: PDF Viewer, defect, P1)

Description

[Rares Doghi, Desktop QA]

Attachment: 2024-09-09_10h58_47.png

Found in

• 132.0a1 (2024-09-08)

Affected versions

• 132.0a1 (2024-09-08)

Preconditions
pdfjs.enableAltText - true
pdfjs.enableUpdatedAddImage - true
browser.ml.enable - true

Affected platforms

• windows

Steps to reproduce

1. Launch an older version of Firefox Nightly
2. Set the Prefs from the preconditions and Update the browser.
3. Add a PDF file to the Firefox browser.
4. Add an image to the PDF.

Expected result

• The "This Alt text was created automatically" label should not be displayed if there is no text in the description field.

Actual result

• The label is displayed while the Description field is empty.

Regression range
This issue does not occur in Beta but there is no way to get a regression range for this issue since it will always update to the latest version.

Comment 1

[BMO Github Automation]

Attachment: [mozilla/pdf.js] [Editor] Avoid to have the ML disclaimer when the ML engine isn't ready (bug 1917543) (#18719)

Comment 2

[Calixte Denizet (:calixte)]

Attachment: Bug 1917543 - Don't display the AI disclaimer when it's unnecessary r=#pdfjs-reviewers

This patch contains an update of pdf.js where the following commits have been cherry-picked

• 4aea51b5bffa6dcebbe80f44652bdc40a0fe853e
• 6e4b7ee3f8618001414e1629a4ac876fb3322b82

Comment 3

[Calixte Denizet (:calixte)]

Attachment: Bug 1917543 - Don't display the AI disclaimer when adding an image in a pdf when it's unnecessary (beta)

This patch contains an update of pdf.js where the following commits have been cherry-picked

• 4aea51b5bffa6dcebbe80f44652bdc40a0fe853e
• 6e4b7ee3f8618001414e1629a4ac876fb3322b82

Original Revision: https://phabricator.services.mozilla.com/D221658

Comment 4

[Ania]

The issue is also reproducible under these conditions:

enableUpdatedAddImage: true
enableAltText: false
browserMlEnable: false

The alt text disclaimer and toggle are visible (despite the two last prefs being set to false).

Comment 5

[Calixte Denizet (:calixte)]

Attachment: Bug 1917543 - Don't display the AI disclaimer when it's unnecessary

This patch contains an update of pdf.js where the following commits have been cherry-picked

• 4aea51b5bffa6dcebbe80f44652bdc40a0fe853e (bug 1911764)
• 6e4b7ee3f8618001414e1629a4ac876fb3322b82 (bug 1917543)

Original Revision: https://phabricator.services.mozilla.com/D221658

Comment 6

[Phabricator Automation]

beta Uplift Approval Request

• User impact if declined: Low
• Code covered by automated testing: yes
• Fix verified in Nightly: no
• Needs manual QE test: yes
• Steps to reproduce for manual QE testing: See the bugs mentioned in the commit message
• Risk associated with taking this patch: low
• Explanation of risk level: it's for an experiment
• String changes made/needed: no
• Is Android affected?: no

Comment 7

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/e984004cf6ba

Comment 8

[Rares Doghi, Desktop QA]

Verified as fixed in our Beta 131.0b5 and our latest Nightly build. This issue was fixed with Bug 1917686.
Should I update the Main status flag to fixed and then Verified ?

Comment 9

[Calixte Denizet (:calixte)]

Attachment: Bug 1917543 - Don't display the AI disclaimer when it's unnecessary

This patch contains an update of pdf.js where the following commits have been cherry-picked

• 4aea51b5bffa6dcebbe80f44652bdc40a0fe853e (bug 1911764)
• 6e4b7ee3f8618001414e1629a4ac876fb3322b82 (bug 1917543)

Comment 10

[Phabricator Automation]

release Uplift Approval Request

• User impact if declined: Low
• Code covered by automated testing: yes
• Fix verified in Nightly: yes
• Needs manual QE test: yes
• Steps to reproduce for manual QE testing: See the bugs mentioned in the commit message
• Risk associated with taking this patch: Low
• Explanation of risk level: it's for an experiment
• String changes made/needed: no
• Is Android affected?: no

Comment 11

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-release/rev/30aa3566e186

Comment 12

[Pascal Chevrel:pascalc]

This fix will be included in our planned 130 dot release, thanks.

Comment 13

[Rares Doghi, Desktop QA]

This is verified as fixed in our latest Release 130.0.1 20240912074333

Comment 14

[Rares Doghi, Desktop QA]

Updating the main status flag.