1917577 - "Decrypt and Open" is not working for an attached OpenPGP key (Console shows: lazy.log is not a function)

Status: RESOLVED FIXED

(MailNews Core :: Security: OpenPGP, defect)

Description

[enxio6]

Steps to reproduce:

I clicked on "Decrypt and Open" on an attached key in asc format

Actual results:

No dialog for importing the key is shown.

The error console showed the following though:

---

14:12:17.659 Uncaught (in promise) TypeError: lazy.log is not a function
decryptAttachment chrome://openpgp/content/modules/decryption.sys.mjs:556
decryptAttachmentCallback chrome://openpgp/content/ui/enigmailMessengerOverlay.js:1998
bufferListener chrome://openpgp/content/ui/enigmailMessengerOverlay.js:1854
onStopRequest chrome://openpgp/content/modules/streams.sys.mjs:50
decryption.sys.mjs:556:12

Following decryption.sys.mjs:556 shows indeed a call to "lazy.log()". Maybe this should be a "lazy.log.debug()" or "...warn()" like in the rest of the module?

Expected results:

A dialog to show the key to imported should have been shown.

Comment 1

[Magnus Melin [:mkmelin]]

Thanks for reporting.

Comment 2

[Magnus Melin [:mkmelin]]

Attachment: Bug 1917577 - Fix incorrect log call in decryption.sys.mjs. r=kaie

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/f47d55b396c7
Fix incorrect log call in decryption.sys.mjs. r=kaie

Comment 4

[Corey Bryant]

Is this ready for beta?

Comment 5

[Kai Engert [:KaiE:]]

yes please

Comment 6

[Kai Engert [:KaiE:]]

This is a trivial obviously correct fix, so it should be fine to directly take for 128, too.

Comment 7

[Kai Engert [:KaiE:]]

Comment on attachment 9423832 [details]
Bug 1917577 - Fix incorrect log call in decryption.sys.mjs. r=kaie

[Approval Request Comment]
Regression caused by (bug #): 1814893
User impact if declined: functionality broken
Testing completed (on c-c, etc.): yes
Risk to taking this patch (and alternatives if risky): zero

[Approval Request Comment]
Regression caused by (bug #):
User impact if declined:
Testing completed (on c-c, etc.):
Risk to taking this patch (and alternatives if risky):

Comment 8

[Corey Bryant]

Comment on attachment 9423832 [details]
Bug 1917577 - Fix incorrect log call in decryption.sys.mjs. r=kaie

[Triage Comment]
Approved for beta

Comment 9

[Daniel Darnell [:dandarnell]]

Thunderbird 131.0b4:
https://hg.mozilla.org/releases/comm-beta/rev/b0f1c21fa56f

Comment 10

[Corey Bryant]

Comment on attachment 9423832 [details]
Bug 1917577 - Fix incorrect log call in decryption.sys.mjs. r=kaie

[Triage Comment]
Approved for esr128

Comment 11

[Daniel Darnell [:dandarnell]]

Thunderbird 128.3.0esr:
https://hg.mozilla.org/releases/comm-esr128/rev/775326985676