1917607 - Introduce random noises to WebGLRenderingContext::readPixels() when fingerprinting protection is enabled

Status: ASSIGNED

(Core :: Privacy: Anti-Tracking, task)

Description

[Tim Huang[:timhuang]]

Introduce random noises to the WebGLRenderingContext::readPixels() function.

Comment 1

[Tim Huang[:timhuang]]

We haven't applied the random noises to the WebGLRenderingContext::readPixels() when fingerprinting protection is enabled. However, we have applied the noises to other functions that extract data from a WebGL context. We need to make the behavior consistent across these APIs.

Comment 2

[Fatih Kilic [:fkilic] (OOO -> Aug 12)]

also getBufferSubData()

Comment 3

[Fatih Kilic [:fkilic] (OOO -> Aug 12)]

Attachment: Bug 1917607: Spoof pixel data in WebGLRenderingContext::readPixels with ArrayView type/non-pbo. r?tjr

Comment 4

[Fatih Kilic [:fkilic] (OOO -> Aug 12)]

Attachment: Bug 1917607: Add image randomization tests for readPixels with ArrayView type. r?tjr

Comment 5

[Fatih Kilic [:fkilic] (OOO -> Aug 12)]

Attachment: Bug 1917607: Extract GetBufferParameter's lambda to GetBufferParameterImpl. r?tjr

Comment 6

[Fatih Kilic [:fkilic] (OOO -> Aug 12)]

Attachment: Bug 1917607: Spoof pixel data in ClientWebGLContext::GetBufferSubData for buffer extraction. r?tjr

Comment 7

[Fatih Kilic [:fkilic] (OOO -> Aug 12)]

Attachment: Bug 1917607: Add image randomization tests for GetBufferSubData. r?tjr

Comment 8

[Fatih Kilic [:fkilic] (OOO -> Aug 12)]

Attachment: Bug 1917607: Implement using placeholder in readpixel function. r?tjr

Comment 9

[Fatih Kilic [:fkilic] (OOO -> Aug 12)]

Attachment: Bug 1917607: Add tests for placeholder. r?tjr

Comment 10

[BugBot [:suhaib / :marco/ :calixte]]

The following patches are waiting for review from an inactive reviewer:

ID	Title	Author	Reviewer Status
D223382	Bug 1917607: Spoof pixel data in WebGLRenderingContext::readPixels with ArrayView type/non-pbo. r?tjr	fkilic	jgilbert: Disabled
D223387	Bug 1917607: Extract GetBufferParameter's lambda to GetBufferParameterImpl. r?tjr	fkilic	jgilbert: Disabled
D223388	Bug 1917607: Spoof pixel data in ClientWebGLContext::GetBufferSubData for buffer extraction. r?tjr	fkilic	jgilbert: Disabled
D227965	Bug 1917607: Implement using placeholder in readpixel function. r?tjr	fkilic	jgilbert: Disabled

:fkilic, could you please find another reviewer or abandon the patch if it is no longer relevant?

For more information, please visit BugBot documentation.

Comment 11

[Fatih Kilic [:fkilic] (OOO -> Aug 12)]

Changed it to gfx-reviewers

Comment 12

[Fatih Kilic [:fkilic] (OOO -> Aug 12)]

Attachment: Bug 1917607: Spoof pixel data in WebGLRenderingContext::readPixels with ArrayView type/non-pbo. r?tjr

Differential Revision https://phabricator.services.mozilla.com/D223382

Comment 13

[Fatih Kilic [:fkilic] (OOO -> Aug 12)]

Attachment: Bug 1917607 - Separate RandomizePixels to two. r?tjr