1917607 - Introduce random noises to WebGLRenderingContext::readPixels() when fingerprinting protection is enabled

Status: RESOLVED FIXED

(Core :: Privacy: Anti-Tracking, task)

Description

[Tim Huang[:timhuang]]

Introduce random noises to the WebGLRenderingContext::readPixels() function.

Comment 1

[Tim Huang[:timhuang]]

We haven't applied the random noises to the WebGLRenderingContext::readPixels() when fingerprinting protection is enabled. However, we have applied the noises to other functions that extract data from a WebGL context. We need to make the behavior consistent across these APIs.

Comment 2

[Fatih Kilic [:fkilic]]

also getBufferSubData()

Comment 3

[Fatih Kilic [:fkilic]]

Attachment: Bug 1917607: Spoof pixel data in WebGLRenderingContext::readPixels with ArrayView type/non-pbo. r?tjr

Comment 4

[Fatih Kilic [:fkilic]]

Attachment: Bug 1917607: Add image randomization tests for readPixels with ArrayView type. r?tjr

Comment 5

[Fatih Kilic [:fkilic]]

Attachment: Bug 1917607: Extract GetBufferParameter's lambda to GetBufferParameterImpl. r?tjr

Comment 6

[Fatih Kilic [:fkilic]]

Attachment: Bug 1917607: Spoof pixel data in ClientWebGLContext::GetBufferSubData for buffer extraction. r?tjr

Comment 7

[Fatih Kilic [:fkilic]]

Attachment: Bug 1917607: Add image randomization tests for GetBufferSubData. r?tjr

Comment 8

[Fatih Kilic [:fkilic]]

Attachment: Bug 1917607: Implement using placeholder in readpixel function. r?tjr

Comment 9

[Fatih Kilic [:fkilic]]

Attachment: Bug 1917607: Add tests for placeholder. r?tjr

Comment 10

[BugBot [:suhaib / :marco/ :calixte]]

The following patches are waiting for review from an inactive reviewer:

ID	Title	Author	Reviewer Status
D223382	Bug 1917607: Spoof pixel data in WebGLRenderingContext::readPixels with ArrayView type/non-pbo. r?tjr	fkilic	jgilbert: Disabled
D223387	Bug 1917607: Extract GetBufferParameter's lambda to GetBufferParameterImpl. r?tjr	fkilic	jgilbert: Disabled
D223388	Bug 1917607: Spoof pixel data in ClientWebGLContext::GetBufferSubData for buffer extraction. r?tjr	fkilic	jgilbert: Disabled
D227965	Bug 1917607: Implement using placeholder in readpixel function. r?tjr	fkilic	jgilbert: Disabled

:fkilic, could you please find another reviewer or abandon the patch if it is no longer relevant?

For more information, please visit BugBot documentation.

Comment 11

[Fatih Kilic [:fkilic]]

Changed it to gfx-reviewers

Comment 12

[Fatih Kilic [:fkilic]]

Attachment: Bug 1917607: Spoof pixel data in WebGLRenderingContext::readPixels with ArrayView type/non-pbo. r?tjr

Differential Revision https://phabricator.services.mozilla.com/D223382

Comment 13

[Fatih Kilic [:fkilic]]

Attachment: Bug 1917607 - Separate RandomizePixels to two. r?tjr

Comment 14

[Nicolas Silva [:nical]]

Attachment: Bug 1917607 - Force ImageRendering::Auto with stacking context snapshots. r=#gfx-reviewers

Comment 15

[Phabricator Automation]

Comment on attachment 9507629 [details]
Bug 1917607 - Force ImageRendering::Auto with stacking context snapshots. r=#gfx-reviewers

Revision D261434 was moved to bug 1983053. Setting attachment 9507629 [details] to obsolete.

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/0d6cca630dae
https://hg.mozilla.org/integration/autoland/rev/47b2dc16e644
Separate RandomizePixels to two. r=tjr
https://github.com/mozilla-firefox/firefox/commit/7198d5ee0d27
https://hg.mozilla.org/integration/autoland/rev/bcfaaf4c1a7b
Spoof pixel data in WebGLRenderingContext::readPixels with ArrayView type/non-pbo. r=gfx-reviewers,nical,timhuang
https://github.com/mozilla-firefox/firefox/commit/a26f5d704d16
https://hg.mozilla.org/integration/autoland/rev/c8083be486d7
Add image randomization tests for readPixels with ArrayView type. r=tjr
https://github.com/mozilla-firefox/firefox/commit/6b52fc19d68e
https://hg.mozilla.org/integration/autoland/rev/d67510d308b3
Spoof pixel data in ClientWebGLContext::GetBufferSubData for buffer extraction. r=tjr,gfx-reviewers,nical
https://github.com/mozilla-firefox/firefox/commit/7656f3ed3a92
https://hg.mozilla.org/integration/autoland/rev/76e9d018ecf4
Add image randomization tests for GetBufferSubData. r=tjr
https://github.com/mozilla-firefox/firefox/commit/8c7eaf3fd31f
https://hg.mozilla.org/integration/autoland/rev/5cc32edf10c7
Implement using placeholder in readpixel function. r=gfx-reviewers,nical,timhuang,ahale
https://github.com/mozilla-firefox/firefox/commit/9afd92bc686b
https://hg.mozilla.org/integration/autoland/rev/ee4a07b97971
Add tests for placeholder. r=tjr

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/88dff89ed3c6
https://hg.mozilla.org/integration/autoland/rev/3790ff1d2acc
Revert "Bug 1917607: Add tests for placeholder. r=tjr" for causing bc failures @ browser_resistfingerprinting_readpixels.js

Comment 18

[amarc]

Backed out for causing bc failures @ browser_resistfingerprinting_readpixels

• Backout link
• Push with failures
• Failure Log

Comment 19

[Tom Ritter [:tjr] (OOTO until April)]

Attachment: WIP: Bug 1917607: Add crash test for readPixels with ArrayView type

Comment 20

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/09657701194b
https://hg.mozilla.org/integration/autoland/rev/3bcbb22d5b91
Separate RandomizePixels to two. r=tjr
https://github.com/mozilla-firefox/firefox/commit/6f6506cecba5
https://hg.mozilla.org/integration/autoland/rev/3dc2ce6d814e
Spoof pixel data in WebGLRenderingContext::readPixels with ArrayView type/non-pbo. r=gfx-reviewers,nical,timhuang
https://github.com/mozilla-firefox/firefox/commit/24b5799459ae
https://hg.mozilla.org/integration/autoland/rev/0ed55e8950e3
Add image randomization tests for readPixels with ArrayView type. r=tjr
https://github.com/mozilla-firefox/firefox/commit/36c01e47d66b
https://hg.mozilla.org/integration/autoland/rev/62f22b7fb074
Spoof pixel data in ClientWebGLContext::GetBufferSubData for buffer extraction. r=tjr,gfx-reviewers,nical
https://github.com/mozilla-firefox/firefox/commit/dfdb171b0a8a
https://hg.mozilla.org/integration/autoland/rev/e9587cdbfde9
Add image randomization tests for GetBufferSubData. r=tjr
https://github.com/mozilla-firefox/firefox/commit/d22fe15dde48
https://hg.mozilla.org/integration/autoland/rev/d8d535554c65
Implement using placeholder in readpixel function. r=gfx-reviewers,nical,timhuang,ahale
https://github.com/mozilla-firefox/firefox/commit/ee8923042e98
https://hg.mozilla.org/integration/autoland/rev/62c92d413916
Add tests for placeholder. r=tjr

Comment 21

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/3bcbb22d5b91
https://hg.mozilla.org/mozilla-central/rev/3dc2ce6d814e
https://hg.mozilla.org/mozilla-central/rev/0ed55e8950e3
https://hg.mozilla.org/mozilla-central/rev/62f22b7fb074
https://hg.mozilla.org/mozilla-central/rev/e9587cdbfde9
https://hg.mozilla.org/mozilla-central/rev/d8d535554c65
https://hg.mozilla.org/mozilla-central/rev/62c92d413916