1917629 - Rework checks for description for Flac and Vorbis

Status: RESOLVED FIXED

(Core :: Audio/Video: Web Codecs, defect)

Description

[Paul Adenot (:padenot)]

See https://bugzilla.mozilla.org/show_bug.cgi?id=1915002#c6

Comment 1

[Paul Adenot (:padenot)]

Attachment: Bug 1917629 - Back out changeset 6ff3f1fba36f because it is incorrect per spec. r?chunmin

This is unfortunately incorrect, it means that:

AudioDecoder.isConfigSupport({codec: "flac", numberOfChannels: 1, sampleRate: 48000});

resolves to a promise that says that it isn't supported (and it should say yes).
Unfortunately, audioDecoder-codec-specific.https.any.js lacked tests for those
two codecs, and the tests added are incorrect. The spec for this is:
https://w3c.github.io/webcodecs/#check-configuration-support, and the check is
intentionally not very thorough: this method is meant to know if this
implementation generally supports a codec, not to check if configure(...) will
success with very specific parameters. In general, isConfigSupported is done
ahead of downloading any media content, so we don't have a description here.

Comment 2

[Paul Adenot (:padenot)]

We'll need this on beta as well. New checks incoming.

Comment 3

[Paul Adenot (:padenot)]

Attachment: Bug 1917629 - Properly check for description presence for flac and vorbis. r?chunmin

Configure need to error out if there's no description, but isConfigSupported
should say true.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6d6a00c29a87
Back out changeset 6ff3f1fba36f because it is incorrect per spec. r=chunmin
https://hg.mozilla.org/integration/autoland/rev/a6af9793cee6
Properly check for description presence for flac and vorbis. r=chunmin

Comment 5

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Failed to create upstream wpt PR due to merge conflicts. This requires fixup from a wpt sync admin.

Comment 6

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/6d6a00c29a87
https://hg.mozilla.org/mozilla-central/rev/a6af9793cee6

Comment 7

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/48305 for changes under testing/web-platform/tests

Comment 8

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 9

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot