1917651 - Ensure that the update success ping is sent before Firefox shuts down

Status: RESOLVED FIXED

(Toolkit :: Application Update, defect)

Description

[Robin Steuber (she/her) [:bytesized]]

We knew that the patch for Bug 1642039 did not ensure that UpdatePing.handleUpdateSuccess resolves before Firefox exits. We considered it low enough of a risk that we did not want to introduce that additional complexity into that already complex patch. But we should still fix this and make sure that we don't shutdown without allowing the function to run to completion.

A reasonable mechanism for this might be using a deferred task that is added as a shutdown blocker, like we do here. This would allow us to make UpdatePing.handleUpdateSuccess synchronous so that we wouldn't need to worry about awaiting on it at its call site.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1642039

:erchen, since you are the author of the regressor, bug 1642039, could you take a look?

For more information, please visit BugBot documentation.

Comment 2

[Robin Steuber (she/her) [:bytesized]]

erchen is on PTO. I think we will have someone else available to work on this soon.

Comment 3

[Greg Tatum [:gregtatum]]

Hey any update on someone looking at this for 132? 132 is going out to beta next week. I'm unclear how bad the S3 is here exactly.

Comment 4

[Robin Steuber (she/her) [:bytesized]]

I'm not really that concerned with ensuring this is fixed before 133. It really shouldn't affect anyone with browser sessions longer than a few seconds. When it does happen, it does not affect anything user-facing - telemetry only.

Comment 5

[Eric Chen]

Attachment: Bug 1917651 - Add a shutdown blocker to ensure update ping will be sent before Firefox exits r=bytesized!

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/be8a232a8424
Add a shutdown blocker to ensure update ping will be sent before Firefox exits r=bytesized,firefox-desktop-core-reviewers ,mossop

Comment 7

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/be8a232a8424

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

Since nightly and release are affected, beta will likely be affected too.
For more information, please visit BugBot documentation.

Comment 9

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:erchen, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox133 to wontfix.

For more information, please visit BugBot documentation.

Comment 10

[Donal Meehan [:dmeehan]]

Setting Fx133 to wontfix, based on comment 4 this does not need a release uplift.
Keeping NI open in case there's any disagreement.