1917664 - Ensure mMSAuthorities is loaded even when the preference is switched

Status: RESOLVED FIXED

(Core :: Networking: HTTP, defect, P2)

Description

[Sean Kim]

Due to !StaticPrefs::network_http_microsoft_entra_sso_enabled(), we don't set the mMSAuthorities if network.http.microsoft-entra-sso.enabled is not set. This is problematic as if user switches pref in between, mMSAuthorities would remain empty hence SSO would not work: https://searchfox.org/mozilla-central/rev/04a47c08504e6357a3164163dd19a47754521204/netwerk/protocol/http/nsHttpHandler.cpp#1080

Comment 1

[Sean Kim]

Attachment: Bug 1917664 - Ensure mMSAuthorities is loaded even when the preference is switched r=#necko

Comment 2

[Sean Kim]

Attachment: Bug 1917664 - Ensure mMSAuthorities is loaded even when the preference is switched

Original Revision: https://phabricator.services.mozilla.com/D221532

Comment 3

[Phabricator Automation]

beta Uplift Approval Request

• User impact if declined: When the pref microsoft-entra-sso.enabled is set from false to true, Microsoft SSO won't be enabled until reopening the browser on macOS.
• Code covered by automated testing: no
• Fix verified in Nightly: no
• Needs manual QE test: no
• Steps to reproduce for manual QE testing: would be difficult to get QA setup (Microsoft Azure)
• Risk associated with taking this patch: Low
• Explanation of risk level: No risk, the component is isolated (can only be enabled by a pref
• String changes made/needed: N/A
• Is Android affected?: no

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dce83ca67c50
Ensure mMSAuthorities is loaded even when the preference is switched r=necko-reviewers,kershaw

Comment 5

[Phabricator Automation]

beta Uplift Approval Request

• User impact if declined: When the pref microsoft-entra-sso.enabled is set from false to true, Microsoft SSO won't be enabled until reopening the browser on macOS.
• Code covered by automated testing: no
• Fix verified in Nightly: no
• Needs manual QE test: no
• Steps to reproduce for manual QE testing: would be difficult to get QA setup (Microsoft Azure). Note that this was tested in a manual signed build.
• Risk associated with taking this patch: Low
• Explanation of risk level: No risk, the component is isolated (can only be enabled by a pref
• String changes made/needed: N/A
• Is Android affected?: no

Comment 6

[Phabricator Automation]

beta Uplift Approval Request

• User impact if declined: When the pref microsoft-entra-sso.enabled is set from false to true, Microsoft SSO won't be enabled until reopening the browser on macOS.
• Code covered by automated testing: no
• Fix verified in Nightly: no
• Needs manual QE test: no
• Steps to reproduce for manual QE testing: would be difficult to get QA setup (Microsoft Azure). Note that this was tested in a manual signed build (Nightly).
• Risk associated with taking this patch: Low
• Explanation of risk level: Low risk since the component is isolated (can only be enabled by a pref; the UI is hidden for now)
• String changes made/needed: N/A
• Is Android affected?: no

Comment 7

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/dce83ca67c50

Comment 8

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/33ae4039e890

Comment 9

[Mike Kaply [:mkaply]]

Attachment: Bug 1917664 - Ensure mMSAuthorities is loaded even when the preference is switched r=#necko

Original Revision: https://phabricator.services.mozilla.com/D221532

Comment 10

[Phabricator Automation]

esr128 Uplift Approval Request

• User impact if declined: SSO feature doens't work until restart
• Code covered by automated testing: no
• Fix verified in Nightly: yes
• Needs manual QE test: no
• Steps to reproduce for manual QE testing: N/A
• Risk associated with taking this patch: Low
• Explanation of risk level: Only impacts SSO feature, has been tested by microsoft
• String changes made/needed: None
• Is Android affected?: no

Comment 11

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-esr128/rev/7b3b55da4bbd