[Toolbar redesign] Add telemetry for knowing how many users have gesture navigation enabled
Categories
(Fenix :: Toolbar, task)
Tracking
(firefox130 wontfix, firefox131 fixed, firefox132 verified)
People
(Reporter: petru, Assigned: petru)
References
(Blocks 1 open bug)
Details
Attachments
(3 files)
48 bytes,
text/x-phabricator-request
|
diannaS
:
approval-mozilla-beta+
diannaS
:
approval-mozilla-release-
|
Details | Review |
59.32 KB,
image/png
|
Details | |
48 bytes,
text/x-phabricator-request
|
diannaS
:
approval-mozilla-beta+
pascalc
:
approval-mozilla-release-
|
Details | Review |
Capturing a new data type:
How many users are using their Android phones with a 3-button navigation bar vs a Gesture navigation bar?
How we might do that:
Check the reported system gesture insets' left and right values to know if on the sides of the screen is an area on which the system gesture - back swipes have priority. Values should be 0
if 3-button navigation is used instead.
Why do we need this?
Aarjav pointed that this will data point that has been requested by Mobile UX leadership to help understand the impact of the new nav bar.
And address the potential redundancy of the back button.
Assignee | ||
Comment 1•9 days ago
|
||
Comment 3•8 days ago
|
||
bugherder |
Comment 4•6 days ago
|
||
Petru, is your new telemetry safe to uplift to Beta 132? Uplifting would help us get more data sooner about back button usage.
Assignee | ||
Comment 5•3 days ago
•
|
||
(In reply to Chris Peterson [:cpeterson] from comment #4)
Petru, is your new telemetry safe to uplift to Beta 132? Uplifting would help us get more data sooner about back button usage.
Yes, I would say so, patch is small with no other dependencies / implications.
Let's first have QA also validate this.
Assignee | ||
Updated•3 days ago
|
Verified as fixed on the latest Nightly 132.0a1 from 09/16 with Google Pixel 8 Pro (Android 14).
Assignee | ||
Comment 7•3 days ago
|
||
Comment on attachment 9423795 [details]
Bug 1917757 - Collect telemetry for if the user has gesture navigation enabled r=#android-reviewers
Beta/Release Uplift Approval Request
- User impact if declined: Less data about user's preference for navigation which would impact development of new features.
- Is this code covered by automated tests?: Yes
- Has the fix been verified in Nightly?: Yes
- Needs manual test from QE?: Yes
- If yes, steps to reproduce: On Android 10+:
- cycle between gestures and navigation buttons in system settings
- open the app
- ensure the
navigation_bar_os_navigation_uses_gestures
metric as part of themetrics
probe has the correct value to indicate what type od navigation is used.
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): Small targeted change, validated by QA.
- String changes made/needed:
- Is Android affected?: Yes
Assignee | ||
Updated•3 days ago
|
Assignee | ||
Comment 8•3 days ago
|
||
Amedyne asked if we could uplift this to release also.
Assignee | ||
Comment 9•3 days ago
|
||
Comment on attachment 9423795 [details]
Bug 1917757 - Collect telemetry for if the user has gesture navigation enabled r=#android-reviewers
Beta/Release Uplift Approval Request
- User impact if declined: Less data about user's preference for navigation which would impact development of new features.
- Is this code covered by automated tests?: Yes
- Has the fix been verified in Nightly?: Yes
- Needs manual test from QE?: Yes
- If yes, steps to reproduce: - cycle between gestures and navigation buttons in system settings
- open the app
- ensure the navigation_bar_os_navigation_uses_gestures metric as part of the metrics probe has the correct value to indicate what type od navigation is used.
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): Small targeted change, validated by QA.
- String changes made/needed:
- Is Android affected?: Yes
Comment 10•2 days ago
|
||
Comment on attachment 9423795 [details]
Bug 1917757 - Collect telemetry for if the user has gesture navigation enabled r=#android-reviewers
Approved for 131.0b8
Comment 11•2 days ago
|
||
uplift |
Updated•2 days ago
|
Comment 12•2 days ago
•
|
||
Backed out beta for causing fenix lint failures
Push with failures
Backout link: https://treeherder.mozilla.org/jobs?repo=mozilla-beta&revision=6bf612c93d4fe07271619302fc868ea2049ab415
Updated•2 days ago
|
Assignee | ||
Comment 13•2 days ago
|
||
I see the following lint error as cause for the lint failure:
HomeActivity.kt:1324: Error: The @SuppressLint annotation cannot be used on a local variable with the lint check 'NewApi': move out to the surrounding method [LocalSuppress]
@SuppressLint("NewApi") // The Android Q check is done in the systemGesturesInsets property getter
Running :app:lintFenixDebug
locally I see no issue and also nothing reported in m-c but will use the recommended approach to move the suppression to the surrounding method.
Assignee | ||
Comment 14•2 days ago
|
||
Fix the reported Lint error when trying to uplift:
Error: The @SuppressLint annotation cannot be used on a local variable with the
lint check 'NewApi': move out to the surrounding method.
Comment 15•2 days ago
|
||
Comment 16•2 days ago
|
||
A patch has been attached on this bug, which was already closed. Filing a separate bug will ensure better tracking. If this was not by mistake and further action is needed, please alert the appropriate party. (Or: if the patch doesn't change behavior -- e.g. landing a test case, or fixing a typo -- then feel free to disregard this message)
Comment 17•1 day ago
|
||
bugherder |
Assignee | ||
Comment 18•1 day ago
|
||
Comment on attachment 9425188 [details]
Bug 1917757 - Update NewApi lint suppression r=#android-reviewers
Beta/Release Uplift Approval Request
- User impact if declined: Less data about user's preference for navigation which would impact development of new features.
- Is this code covered by automated tests?: Yes
- Has the fix been verified in Nightly?: Yes
- Needs manual test from QE?: Yes
- If yes, steps to reproduce: - open the app
- ensure the navigation_bar_os_navigation_uses_gestures metric as part of the metrics probe has the correct value to indicate what type od navigation is used.
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): Small targeted change, validated by QA.
- String changes made/needed:
- Is Android affected?: Yes
Comment 19•1 day ago
|
||
Comment on attachment 9425188 [details]
Bug 1917757 - Update NewApi lint suppression r=#android-reviewers
Approved for 131.0b8
Updated•1 day ago
|
Comment 20•1 day ago
|
||
uplift |
Updated•1 day ago
|
Updated•14 hours ago
|
Updated•9 hours ago
|
Description
•