1917757 - [Toolbar redesign] Add telemetry for knowing how many users have gesture navigation enabled

Status: RESOLVED FIXED

(Firefox for Android :: Toolbar, task)

Description

[Petru-Mugurel Lingurar [:petru]]

Capturing a new data type:

How many users are using their Android phones with a 3-button navigation bar vs a Gesture navigation bar?

How we might do that:

Check the reported system gesture insets' left and right values to know if on the sides of the screen is an area on which the system gesture - back swipes have priority. Values should be 0 if 3-button navigation is used instead.

Why do we need this?

Aarjav pointed that this will data point that has been requested by Mobile UX leadership to help understand the impact of the new nav bar.
And address the potential redundancy of the back button.

Comment 1

[Petru-Mugurel Lingurar [:petru]]

Attachment: Bug 1917757 - Collect telemetry for if the user has gesture navigation enabled r=#android-reviewers

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/09acea923c77
Collect telemetry for if the user has gesture navigation enabled r=android-reviewers,gmalekpour

Comment 3

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/09acea923c77

Comment 4

[Chris Peterson [:cpeterson]]

Petru, is your new telemetry safe to uplift to Beta 132? Uplifting would help us get more data sooner about back button usage.

Comment 5

[Petru-Mugurel Lingurar [:petru]]

(In reply to Chris Peterson [:cpeterson] from comment #4)

Petru, is your new telemetry safe to uplift to Beta 132? Uplifting would help us get more data sooner about back button usage.

Yes, I would say so, patch is small with no other dependencies / implications.
Let's first have QA also validate this.

Comment 6

[Delia Pop (Android QA)]

Attachment: Nightly132.png

Verified as fixed on the latest Nightly 132.0a1 from 09/16 with Google Pixel 8 Pro (Android 14).

Comment 7

[Petru-Mugurel Lingurar [:petru]]

Comment on attachment 9423795 [details]
Bug 1917757 - Collect telemetry for if the user has gesture navigation enabled r=#android-reviewers

Beta/Release Uplift Approval Request

• User impact if declined: Less data about user's preference for navigation which would impact development of new features.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: On Android 10+:

• cycle between gestures and navigation buttons in system settings
• open the app
• ensure the navigation_bar_os_navigation_uses_gestures metric as part of the metrics probe has the correct value to indicate what type od navigation is used.

• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Small targeted change, validated by QA.
• String changes made/needed:
• Is Android affected?: Yes

Comment 8

[Petru-Mugurel Lingurar [:petru]]

Amedyne asked if we could uplift this to release also.

Comment 9

[Petru-Mugurel Lingurar [:petru]]

Comment on attachment 9423795 [details]
Bug 1917757 - Collect telemetry for if the user has gesture navigation enabled r=#android-reviewers

Beta/Release Uplift Approval Request

• User impact if declined: Less data about user's preference for navigation which would impact development of new features.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: - cycle between gestures and navigation buttons in system settings
  • open the app
  • ensure the navigation_bar_os_navigation_uses_gestures metric as part of the metrics probe has the correct value to indicate what type od navigation is used.
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Small targeted change, validated by QA.
• String changes made/needed:
• Is Android affected?: Yes

Comment 10

[Dianna Smith [:diannaS]]

Comment on attachment 9423795 [details]
Bug 1917757 - Collect telemetry for if the user has gesture navigation enabled r=#android-reviewers

Approved for 131.0b8

Comment 11

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/a06e97b5e13c

Comment 12

[Dianna Smith [:diannaS]]

Backed out beta for causing fenix lint failures
Push with failures
Backout link: https://treeherder.mozilla.org/jobs?repo=mozilla-beta&revision=6bf612c93d4fe07271619302fc868ea2049ab415

Comment 13

[Petru-Mugurel Lingurar [:petru]]

I see the following lint error as cause for the lint failure:

HomeActivity.kt:1324: Error: The @SuppressLint annotation cannot be used on a local variable with the lint check 'NewApi': move out to the surrounding method [LocalSuppress]

     @SuppressLint("NewApi") // The Android Q check is done in the systemGesturesInsets property getter

Running :app:lintFenixDebug locally I see no issue and also nothing reported in m-c but will use the recommended approach to move the suppression to the surrounding method.

Comment 14

[Petru-Mugurel Lingurar [:petru]]

Attachment: Bug 1917757 - Update NewApi lint suppression r=#android-reviewers

Fix the reported Lint error when trying to uplift:
Error: The @SuppressLint annotation cannot be used on a local variable with the
lint check 'NewApi': move out to the surrounding method.

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4ec2f2f3c736
Update NewApi lint suppression r=android-reviewers,sfamisa

Comment 16

[BugBot [:suhaib / :marco/ :calixte]]

A patch has been attached on this bug, which was already closed. Filing a separate bug will ensure better tracking. If this was not by mistake and further action is needed, please alert the appropriate party. (Or: if the patch doesn't change behavior -- e.g. landing a test case, or fixing a typo -- then feel free to disregard this message)

Comment 17

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/4ec2f2f3c736

Comment 18

[Petru-Mugurel Lingurar [:petru]]

Comment on attachment 9425188 [details]
Bug 1917757 - Update NewApi lint suppression r=#android-reviewers

Beta/Release Uplift Approval Request

• User impact if declined: Less data about user's preference for navigation which would impact development of new features.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: - open the app
  • ensure the navigation_bar_os_navigation_uses_gestures metric as part of the metrics probe has the correct value to indicate what type od navigation is used.
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Small targeted change, validated by QA.
• String changes made/needed:
• Is Android affected?: Yes

Comment 19

[Dianna Smith [:diannaS]]

Comment on attachment 9425188 [details]
Bug 1917757 - Update NewApi lint suppression r=#android-reviewers

Approved for 131.0b8

Comment 20

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/ce39c3ad77b0
https://hg.mozilla.org/releases/mozilla-beta/rev/cd9dbb3c4a1d

Comment 21

[Lorand Janos]

Hi,
I managed to re-verify this in Nightly (132.0a1 from 2024-09-18).
We managed to get the log on Beta 131.0b8 as well after many tried steps.
Tested on a Samsung Galaxy S23 Ultra (Android 14) and on Google Pixel 7 Pro ( Android 14).

Comment 22

[Lorand Janos]

Attachment: nightly132.png

Comment 23

[Lorand Janos]

Attachment: beta 131-0b8.png