1917818 - Sync the toolbar position with the keyboard height in browser

Status: RESOLVED FIXED

(Firefox for Android :: Toolbar, defect, P2)

Description

[Petru-Mugurel Lingurar [:petru]]

Attachment: CurrentUI.mp4

As a followup to bug 1911042 and as a suggestion from Sarah in https://phabricator.services.mozilla.com/D219636#7611808 we should also ensure that when browsing and interacting with an input element on the webpage the bottom toolbar is always shown at the top of the keyboard when this is expanded/collapsed for a smoother UI.

Comment 1

[Chris Peterson [:cpeterson]]

Attachment: screenshot_mid_animation.png

Petru, is this bug about the space between the address bar and the animating keyboard? That sounds like a bug, not an enhancement. Will your fix for homepage bug 1911042 not fix this issue for input elements on web pages?

Does this bug affect the old address bar without the new navbar enabled?

Comment 2

[Petru-Mugurel Lingurar [:petru]]

is this bug about the space between the address bar and the animating keyboard

Yes, thanks for the screenshot, caught it just great!

That sounds like a bug, not an enhancement

Agree the distinction here is small, seeing bug 1911042 marked as a defect I'll mark this as such also.
Important to note: we can only solve this on Android10+ as only then Android added APIs to allow us to build the needed functionality.

Will your fix for homepage bug 1911042 not fix this issue for input elements on web pages

bug 1911042 will only address the scenario of using our search screen which has it's own separate toolbar.
Tapping on the address bar will open this other search screen with the new animation for it's toolbar
But when interacting with an input element we are still on the browser screen and need to animate the toolbar from this screen.

Does this bug affect the old address bar without the new navbar enabled?

This is not related to the navbar. To me it's almost the expected functionality, happens on all Android versions with any element that would need to be shown on top of the keyboard.
We could decide to only add a fix for one version of the toolbar (with or without the navbar) but I'd say it's a too great enhancement to not have it for all scenarios.

Comment 3

[Petru-Mugurel Lingurar [:petru]]

Attachment: WIP: Bug 1917818 - Synchronize showing showing the browser input toolbar on top of the keyboard

Comment 4

[Petru-Mugurel Lingurar [:petru]]

Attachment: Bug 1917818 - part 1 - Synchronize showing browser's bottom toolbar on top of the keyboard r=#android-reviewers

Previously when the keyboard would be showing / hiding the entire screen will first resize to
the end height after which the keyboard will be animated.
This meant just one reflow for the engine view but a choppy layout animation.

With the new changes we'll ensure the bottom toolbar is animated in sync with the keyboard
and the engine view is resized only once

• before hiding the keyboard to ensure that it will then nicely reveal the web content
• after showing the full keyboard to ensure it gradually covered web content with no UI issue

Comment 5

[Petru-Mugurel Lingurar [:petru]]

Attachment: Bug 1917818 - part 2 - Improve browser layout with top toolbar updates when the keyboard is animated r=#android-reviewers

Previously when the keyboard would be showing the entire screen will first resize to the end height
after which the keyboard will be animated over an empty content.
With these changes we postpone the resize to after the keyboard animation is finished to ensure a
smooth animation over the web content instead of over empty space.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/37c3cc81d47f
part 1 - Synchronize showing browser's bottom toolbar on top of the keyboard r=android-reviewers,sfamisa
https://hg.mozilla.org/integration/autoland/rev/f090c198cc2f
part 2 - Improve browser layout with top toolbar updates when the keyboard is animated r=android-reviewers,skhan

Comment 7

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/37c3cc81d47f
https://hg.mozilla.org/mozilla-central/rev/f090c198cc2f

Comment 8

[Delia Pop (Android QA)]

Attachment: media_20241017_161734_4096189000533751876.mp4

Verified as fixed in the latest Nightly 13.0a1 from 10/17 with Samsung Tab S8 Ultra 5G (Android 14) and Google Pixel 8 Pro (Android 14).

Comment 9

[Delia Pop (Android QA)]

Attachment: old_toolbar.mp4

Verified as fixed with the old toolbar as well.

Comment 10

[Petru-Mugurel Lingurar [:petru]]

The patch for this has been backed out pending more investigation of padding issues caused by it.

Comment 11

[Petru-Mugurel Lingurar [:petru]]

The patches for this landed in as part of bug 1911042.