1917938 - build still failing on windows with "tarfile.StreamError" error message

Status: RESOLVED DUPLICATE of bug 1916985

(Firefox Build System :: Toolchains, defect)

Description

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

On my Windows loaner, after updating m-c to latest (which includes the fix for bug 1916985), doing a ./mach clobber, I'm still getting the same error when I attempt to do a full build.

Possibly useful device info: this is a Dell XPS 15 running Windows 11 Pro x64. Mozillabuild version is 4.1. I'm a git cinnabar user.

Here's the last bit of ./mach build output, including the error traceback:

 0:08.39 Updating bootstrapped toolchain in C:/Users/Mozilla/.mozbuild/clang
 0:10.83 Setting up artifact clang.tar.zst
 0:10.83 Downloading artifact to local cache: C:\Users\Mozilla\.mozbuild\toolchains\edb9a3c5a748aaee-clang.tar.zst
 0:10.97 Downloading... 0.0 %
(snipped)
 0:49.29 Downloading... 100.0 %
 0:51.57 rm tree: C:\Users\Mozilla\.mozbuild\clang
 0:52.22 untarring "C:\Users\Mozilla\.mozbuild\clang.tar.zst"
 1:01.24 Error running mach:
 1:01.24     mach --log-no-times artifact toolchain --from-task FLbVutdURH-CICppIk_rDQ:public/build/clang.tar.zst
 1:01.24 The error occurred in code that was called by the mach command. This is either
 1:01.24 a bug in the called code itself or in the way that mach is calling it.
 1:01.24 You can invoke ``./mach busted`` to check if this issue is already on file. If it
 1:01.24 isn't, please use ``./mach busted file artifact`` to report it. If ``./mach busted`` is
 1:01.24 misbehaving, you can also inspect the dependencies of bug 1543241.
 1:01.24 If filing a bug, please include the full output of mach, including this error
 1:01.24 message.
 1:01.24 The details of the failure are as follows:
 1:01.24 tarfile.StreamError: seeking backwards is not allowed
 1:01.24   File "C:\mozilla-source\mozilla-unified\python\mozbuild\mozbuild\artifact_commands.py", line 590, in artifact_toolchain
 1:01.24     unpack_file(local)
 1:01.24   File "c:\mozilla-source\mozilla-unified\python\mozbuild\mozbuild\action\tooltool.py", line 1046, in unpack_file
 1:01.26     safe_extract(tar)
 1:01.26   File "c:\mozilla-source\mozilla-unified\python\mozbuild\mozbuild\action\tooltool.py", line 1022, in safe_extract
 1:01.26     tar.extractall(path, members=_files(tar, path), numeric_owner=numeric_owner)
 1:01.26   File "c:\mozilla-source\mozilla-unified\python\mozbuild\mozbuild\action\tooltool.py", line 1008, in extractall
 1:01.26     super(TarFile, self).extractall(*args, **kwargs)
 1:01.26   File "D:\mozilla-build\python3\Lib\tarfile.py", line 2264, in extractall
 1:01.26     self._extract_one(tarinfo, path, set_attrs=not tarinfo.isdir(),
 1:01.26   File "D:\mozilla-build\python3\Lib\tarfile.py", line 2327, in _extract_one
 1:01.26     self._extract_member(tarinfo, os.path.join(path, tarinfo.name),
 1:01.26   File "D:\mozilla-build\python3\Lib\tarfile.py", line 2418, in _extract_member
 1:01.26     self.makelink(tarinfo, targetpath)
 1:01.26   File "D:\mozilla-build\python3\Lib\tarfile.py", line 2519, in makelink
 1:01.26     self._extract_member(self._find_link_target(tarinfo),
 1:01.26   File "D:\mozilla-build\python3\Lib\tarfile.py", line 2410, in _extract_member
 1:01.26     self.makefile(tarinfo, targetpath)
 1:01.26   File "D:\mozilla-build\python3\Lib\tarfile.py", line 2453, in makefile
 1:01.26     source.seek(tarinfo.offset_data)
 1:01.26   File "D:\mozilla-build\python3\Lib\tarfile.py", line 520, in seek
 1:01.26     raise StreamError("seeking backwards is not allowed")
 1:01.26 Sentry event ID: 8f15a5931d404a579effa3bd96ded86e
 1:01.35 Sentry is attempting to send 0 pending error messages
 1:01.35 Waiting up to 2 seconds
 1:01.35 Press Ctrl-Break to quit
 1:01.79 ERROR: Command '['C:\\Users\\Mozilla\\.mozbuild\\srcdirs\\mozilla-unified-f689344771d4\\_virtualenvs\\build\\Scripts\\python.exe', 'C:/mozilla-source/mozilla-unified/mach', '--log-no-times', 'artifact', 'toolchain', '--from-task', 'FLbVutdURH-CICppIk_rDQ:public/build/clang.tar.zst']' returned non-zero exit status 1.
 1:01.79 ERROR: If you can't fix the above, retry with --disable-bootstrap.
*** Fix above errors and then restart with "./mach build"

Comment 1

[Mike Hommey [:glandium]]

dang it, I landed the wrong patch.

Comment 2

[Mike Hommey [:glandium]]

I asked for bug 1916985 to be backed out to get the right patch from there to reland.

Comment 3

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

No worries, glad it's a simple fix!