1918010 - Changing the first day of the week doesn't always update the views properly

Status: RESOLVED FIXED

(Calendar :: Calendar Frontend, defect)

Description

[Geoff Lankow (:darktrojan)]

Bug 1660692 changed the week info service to use a lazy preference getter on calendar.week.start to avoid looking it up every time. But if a change to the preferences causes a different observer (e.g. the one on the calendar views) to ask the service what the start of the week is, it might give the old answer. This is because preferences observers can be fired in any order.

I'm going to go back to looking up the answer every time, as it doesn't get called too often.

Comment 1

[Geoff Lankow (:darktrojan)]

Oh great, the week view doesn't update at all when the first day of the week is set.

Comment 2

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1918010 - Fix updating the calendar views when the first day of the week pref changes. r=#thunderbird-reviewers

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/39c81744e6a5
Fix updating the calendar views when the first day of the week pref changes. r=mkmelin