Closed Bug 1918022 Opened 1 year ago Closed 1 month ago

chromeos.dev - Broken page layout

Categories

(Web Compatibility :: Site Reports, defect, P3)

Desktop
Windows 10

Tracking

(Webcompat Priority:P3, Webcompat Score:3, firefox-esr115 wontfix, firefox-esr140 wontfix, firefox152 fixed, firefox153 verified, firefox154 fixed)

VERIFIED FIXED
Webcompat Priority P3
Webcompat Score 3
Tracking Status
firefox-esr115 --- wontfix
firefox-esr140 --- wontfix
firefox152 --- fixed
firefox153 --- verified
firefox154 --- fixed

People

(Reporter: ctanase, Unassigned)

References

()

Details

(Keywords: webcompat:platform-bug, webcompat:site-report, Whiteboard: [webcompat-source:web-bugs])

User Story

platform:windows,mac,linux,android
impact:significant-visual
configuration:general
affects:all
branch:release
diagnosis-team:layout
user-impact-score:40

Attachments

(1 file)

Environment:
Operating system: Linux / Windows 10
Firefox version: Firefox 115.0/130/132

Steps to reproduce:

  1. Go to https://chromeos.dev/en/add-to-chromebook-badge
  2. Observe the page.

Expected Behavior:
The page is rendered correctly.

Actual Behavior:
The page layout is broken.

Notes:

  • Reproduces regardless of the status of ETP
  • Reproduces in Firefox Nightly, and Firefox Release
  • Does not reproduce in Chrome

Created from https://github.com/webcompat/web-bugs/issues/141459

Attached image image.png
Severity: -- → S3
User Story: (updated)
Priority: -- → P3

This seems to be a dependency on a style container-query, specifically this:

@container style(--inline-aside: 1) {
    .guidelines--section[data-astro-cid-twgynu74] {
        grid-column: 3 / span 3;
    }
}

https://chromeos.dev/_astro/add-to-chromebook-badge.C2FZ22qf.css

Firefox doesn't recognize that style. If I untick that style in Chrome, they change to match our broken rendering. And if I remove the container-query in Firefox and just directly add that style to the .guidelines--section elements' inline styles, Firefox changes to match Chrome's good rendering.

We probably won't be fixing bug 1795622 right away, so in the meantime it'd be nice to get this addressed on the website's side so that it doesn't fail quite so catastrophically in browsers that lack @container style support.

Adding needs-contact to see if we can get Google to update their CSS here so that it fails a bit more gracefully in browsers that fail to parse that @container style rule that I quoted in comment 2.

Webcompat Priority: --- → P2
Webcompat Score: --- → 6
Webcompat Score: 6 → 5
Webcompat Score: 5 → 3
User Story: (updated)
Webcompat Priority: P2 → P3

This is working in Nightly now, as we've enabled @container style queries and enough of the functionality is implemented to support this.

Do we still want to follow up on comment 3, for browsers (incl. Firefox release versions, for now) that don't yet implement style() queries?

User Story: (updated)

(In reply to Jonathan Kew [:jfkthame] from comment #4)

This is working in Nightly now, as we've enabled @container style queries and enough of the functionality is implemented to support this.

Hooray! (Looks like it's guarded to be Nightly-only for now, so let's keep this site-report bug open until it's riding the trains.)

Do we still want to follow up on comment 3, for browsers (incl. Firefox release versions, for now) that don't yet implement style() queries?

Probably not worth spending resources pushing for a site fix at this point, given that we'll have this fixed in the not-too-distant future (and I expect the https://chromeos.dev/ audience -- i.e. folks viewing Chrome OS developer documentation -- is more likely than the broader web to be on a modern browser [particularly Chrome].)

(In reply to Daniel Holbert [:dholbert] from comment #5)

(In reply to Jonathan Kew [:jfkthame] from comment #4)

This is working in Nightly now, as we've enabled @container style queries and enough of the functionality is implemented to support this.

Hooray! (Looks like it's guarded to be Nightly-only for now, so let's keep this site-report bug open until it's riding the trains.)

Update: style container queries were enabled by default for all release channels in bug 2030645.

I also confirmed that I get Expected behavior in default-configured Firefox 151.0.4 as well as Nightly 153.0a1 2026-06-15, and I can bring back the broken behavior by turning the pref off (setting layout.css.style-queries.enabled to false)

So: we can consider this FIXED, and let's change the platform-bug to bug 2030645 since that's the proximal thing that fixed this.

Depends on: 2030645
No longer depends on: container-style-queries
Status: NEW → RESOLVED
Closed: 1 month ago
Resolution: --- → FIXED

Verified, the issue no longer reproduces.

Tested with:

  • Browser / Version: Firefox 153.0-candidate build 1
  • Operating System: Windows 10
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: