1918041 - Clicking the New Tab button does not show pressed appearance with vertical tabs

Status: ASSIGNED

(Firefox :: Sidebar, defect, P3)

Description

[Kestrel]

Attachment: Comparing New Tab button pressed appearance

STR:

1. Start with sidebar.verticalTabs = true and sidebar.revamp = true.
2. Left-click and hold on the New Tab button in the sidebar.

Expected:
Button changes color to appear pressed like the New Tab button in the titlebar.

Actual:
Button appearance does not change when clicked.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:sclements, could you have a look please?

For more information, please visit BugBot documentation.

Comment 2

[Oways Jaffer]

Hi!
I'd like to start contributing and have this be my first bug. Could I please have this assigned.

Comment 3

[Nikki Sharpley (:nikkis) (she/her)]

Hi Oways. Thanks for your interest. Here is a good guide to getting started: https://firefox-source-docs.mozilla.org/contributing/contribution_quickref.html#firefox-contributors-quick-reference
Please reach out if you need any help and feel free to tag me as a reviewer with "nsharpley".

Comment 4

[Oways Jaffer]

Just an update, I've figured out what the issue is and will fix very soon

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

This good-first-bug hasn't had any activity for 2 months, it is automatically unassigned.
For more information, please visit BugBot documentation.

Comment 6

[Mary Ojo]

Hi @Nikki, I'd like to pick this up

Comment 7

[Daniel Furmanov]

Hello!
Can I be assigned this task?

Comment 8

[Sarah Clements [:sclements]]

(In reply to Daniel Furmanov from comment #7)

Hello!
Can I be assigned this task?

Hi Daniel, I've assigned this bug to you. Please use the "request information" button below directed to nsharpley if you have any questions; she is the mentor for this bug if you have any questions. If you decide at some point you no longer want to work on this bug, please also let us know so we can assign it to someone else.

Comment 9

[Daniel Furmanov]

(In reply to Sarah Clements [:sclements] from comment #8)

(In reply to Daniel Furmanov from comment #7)

Hello!
Can I be assigned this task?

Hi Daniel, I've assigned this bug to you. Please use the "request information" button below directed to nsharpley if you have any questions; she is the mentor for this bug if you have any questions. If you decide at some point you no longer want to work on this bug, please also let us know so we can assign it to someone else.

Hello, I have resolved the bug and pushed the commit to Moz-Phab submit.

Comment 10

[Nikki Sharpley (:nikkis) (she/her)]

Hi Daniel. Thanks for submitting a patch. I cannot see the patch though, could you please link to it here? You may need to ensure your commit message has the following format? Bug 1918041 - Commit message title r=nsharpley

Comment 11

[Daniel Furmanov]

Attachment: WIP: Bug 1918041- Add hover and active states to vertical tabs New Tab button

The #vertical-tabs-newtab-button was missing hover and active background
states, causing it to appear visually unresponsive compared to the
horizontal tab strip New Tab button.

Added:

• &:hover background of rgba(0,0,0,0.08) to match toolbar button hover
  appearance
• &:hover:active background of rgba(0,0,0,0.15) to give a pressed/held
  visual state consistent with --toolbarbutton-active-background behavior
  already applied to the horizontal equivalent

Comment 12

[Daniel Furmanov]

(In reply to Nikki Sharpley (:nikkis) (she/her) from comment #10)

Hi Daniel. Thanks for submitting a patch. I cannot see the patch though, could you please link to it here? You may need to ensure your commit message has the following format? Bug 1918041 - Commit message title r=nsharpley

Hi Nikki. Just submitted again, was a little confused on Moz-Phab, but it should be available now.

https://phabricator.services.mozilla.com/D286716

Comment 13

[Kelly Cochrane [:kcochrane]]

Hi, Daniel. We'd added some feedback in your patch if you wouldn't mind addressing when you get the chance. Thanks!

Comment 14

[BugBot [:suhaib / :marco/ :calixte]]

Redirect a needinfo that is pending on an inactive user to the triage owner.
:kcochrane, since the bug has recent activity, could you please find another way to get the information or close the bug as INCOMPLETE if it is not actionable?

For more information, please visit BugBot documentation.