1918097 - Add profiler markers for Glean::CounterMetric

Status: RESOLVED FIXED

(Toolkit :: Telemetry, task)

Comment 1

[Adam Brouwers-Harries [:aabh] [he/him] ⌚GMT]

Attachment: Bug 1918097 - Add profiler markers for Glean::CounterMetric, and name lookup function r?chutten,florian

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ad87df541795
Add profiler markers for Glean::CounterMetric, and name lookup function r=chutten,florian,canaltinova

Comment 3

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a2b3201696a3
Backed out 3 changesets (bug 1918097, bug 1918191, bug 1918172) for causing xpcshell crashes on test_logFromPreference.js CLOSED TREE

Comment 4

[Nazım Can Altınova [:canova][:canaltinova on phabricator]]

I was randomly testing adding Services.profiler.Pause(); to xpcom/tests/unit/test_logFromPreference.js right before we call Services.profiler.getProfileDataAsync and it seems like it's fixing the crash. See the try run here: https://treeherder.mozilla.org/jobs?repo=try&revision=df94ddbef3010569504409777f6dc7512ab92f18

So it looks like a memory corruption during the profiler profile capture when we don't pause the profiler. It's likely that we are writing to somewhere we shouldn't or we are not managing the lifetime of an object properly for these cases? So we definitely need to investigate this memory corruption inside the rust marker API. But considering that we already have markers (with and without payloads) in the tree, I suggest we:

1. Fix the test by adding a pause right before we capture the profile and continue landing these patches, without disabling the markers in Android.
2. Add a debug assert to profile collection to make sure the profiler is paused already. Note that this might generate some assert failures in some test, so we need to fix them by adding some Pause calls to those tests as well.
3. File a bug about this memory corruption so we can investigate it.

Comment 5

[Adam Brouwers-Harries [:aabh] [he/him] ⌚GMT]

Attachment: Bug 1918097 - Pause the profiler to avoid racy memory corruption r?florian,canaltinova

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4f847cf0a431
Pause the profiler to avoid racy memory corruption r=florian

Comment 7

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/4f847cf0a431

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a7c54e7ceaed
Add profiler markers for Glean::CounterMetric, and name lookup function r=chutten,florian,canaltinova

Comment 9

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/a7c54e7ceaed