1918196 - Add telemetry probe to detect failure to setup the fine-grained deadlock avoidance strategy on Windows

Status: NEW

(Core :: Gecko Profiler, enhancement, P3)

Description

[Yannis Juglaret [:yannis]]

After bug 1839299 we will have two strategies to avoid deadlocks in the profiler (and the background hang reporter). The first strategy can fail to setup if there are unexpected opcodes in the functions that we hook (RtlAcquireSRWLockShared, RtlReleaseSRWLockShared). In that case we fall back to the second strategy which is the one that has always been in use this far (stack walk suppressions). It would be good to have telemetry about failure to setup the first strategy, because that could inform us about the specific Windows versions for which we have to adjust our hooks, so that everybody can benefit from the first strategy.

Comment 1

[Yannis Juglaret [:yannis]]

With the final implementation chosen for bug 1839299, there is no hooking involved so no failures due to unexpected opcodes should occur. It could still be interesting to have telemetry about failures, but there are less chances that this telemetry will actually prove itself useful.