Open Bug 1918263 Opened 2 years ago Updated 2 years ago

Ensure the updater doesn't start of its own accord during update testing

Categories

(Toolkit :: Application Update, defect)

defect

Tracking

()

People

(Reporter: bytesized, Unassigned)

References

Details

(Keywords: good-first-bug, Whiteboard: [fidedi-ope])

Our tests are intended to not set app.update.disabledForTesting to false until the testing update URL is set to ensure we don't hit the real update server (causing the test to automatically fail). But I think that even if we do that properly, the tests could still have the updater try to run normally (just with the test URL) without the test intentionally invoking it, likely interfering with the test and causing it to fail in an unpredictable way. I think we should refactor this code out into its own getter and check in with it during the automatic update entry points to prevent this from happening. We probably want to do that here and here.

Obviously this will not work properly if we want to test those exact code paths. But I don't think we ever actually do that.

You need to log in before you can comment on or make changes to this bug.