1918400 - Capture old state for view transitions

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, task, P3)

Description

[Emilio Cobos Álvarez (:emilio)]

We'll need to run https://drafts.csswg.org/css-view-transitions-1/#capture-the-old-state at the appropriate time to ensure we generate the right transition names.

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1918400 - Add some CC helpers to nsBaseHashtable. r=smaug,#xpcom-reviewers

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1918400 - Introduce ViewTransition::mNamedElements. r=#vt

Leave a few TODOs for images and style rule definitions which we're
likely to implement somewhat differently.

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1918400 - Implement most of "capture the old state". r=#vt

See TODO's for follow-up work. We're still not using this, so no
behavior change.

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1918400 - Implement more of view transition's "capture the new state". r=#vt

This should be enough to start setting up the pseudo-element tree.

Comment 5

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1918400 - Update test expectations. r=#vt

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a23c35d79198
Add some CC helpers to nsBaseHashtable. r=smaug,xpcom-reviewers,nika

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a24939805125
Appease GCC build.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b254504c59df
Introduce ViewTransition::mNamedElements. r=view-transitions-reviewers,boris

Comment 9

[Phabricator Automation]

Comment on attachment 9432306 [details]
Bug 1918400 - Implement more of view transition's "capture the new state". r=#vt

Revision D226362 was moved to bug 1918402. Setting attachment 9432306 [details] to obsolete.

Comment 10

[agoloman]

https://hg.mozilla.org/mozilla-central/rev/a23c35d79198
https://hg.mozilla.org/mozilla-central/rev/a24939805125
https://hg.mozilla.org/mozilla-central/rev/b254504c59df

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2dadcdaf81d1
Implement most of "capture the old state". r=view-transitions-reviewers,boris

Comment 12

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/2dadcdaf81d1