1918521 - Can't type leap year in date input (because we think it's a wrong date when typing the year?)

Status: VERIFIED FIXED

(Core :: Layout: Form Controls, defect, P3)

Description

[Hui Li]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/128.0.0.0 Safari/537.36

Steps to reproduce:

I created a playcode to create this.
02/29/2024, or any leap year can't be inserted to date input.
This happens only when firefox browser is used.

https://playcode.io/2005664

Actual results:

After keyboard input 02292024, the input display is mm/dd/0004.

Expected results:

After keyboard input 02292024, the input display is 02/29/2024

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Core::Layout: Form Controls' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[Emilio Cobos Álvarez [:emilio]]

If you insert the year first then it works... But yeah this looks wrong.

Relevant code is here, I suspect something in setinputvaluefromfields or so ends up clearing the input.

I'd be happy to mentor someone to fix this...

Comment 3

[tannal2409]

A simple fix might be deleting this line https://searchfox.org/mozilla-central/rev/181e5bb2645236a617d42e3740420098097f7a0f/toolkit/content/widgets/datetimebox.js#1175.
Can I debug toolkit/content/widgets/datetimebox.js in firefox devtools just like regular js files?
I didn't find it in the debugger panel (using ctrl + p).

Comment 4

[Emilio Cobos Álvarez [:emilio]]

You can do it with the browser toolbox.

Comment 5

[tannal2409]

Attachment: Bug 1918521 - Remove SetInputValueFromFields when handlekeydown in datetimebox. r?emilio

User might still typing even if all three fields are not empty.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/66f309dfb9c2
Remove SetInputValueFromFields  when handlekeydown in datetimebox. r=emilio

Comment 7

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/66f309dfb9c2

Comment 8

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

Reproducible on a 2024-09-12 Nightly build on Windows 10.
Verified as fixed on Firefox 133.0b1 and Firefox Nightly 134.0a1 on Windows 10, macOS 14, Ubuntu 22.