1918538 - We probably don't need the MOZ_SANDBOXED env var

Status: RESOLVED FIXED

(Core :: Security: Process Sandboxing, task)

Description

[Jed Davis [:jld] ⟨⏰|UTC-7⟩ ⟦he/him⟧]

Right now, the MOZ_SANDBOXED env var is used in two places:

• In SandboxReporterClient, as a safety check around the fixed file descriptor number used to pass the socket to child processes
• In shared memory, to see if a process should expect to be blocked from accessing /proc / shouldn't expect to create freezeable shared memory

Bug 1440207, as pointed out by Nika in D221375, should fix the issue with SandboxReporter, and for shared memory we could just use XRE_IsParentProcess to mean “can freeze shared memory” instead of checking for sandboxedness. (And if there's ever a non-sandboxed child process type that needs to freeze shared memory we can always add it in. If we need to freeze shared memory in a sandboxed process on Linux… there are ways to deal with that but that's outside the scope of this bug.)

Comment 1

[:gerard-majax]

This is now blocking landing because of GPU process getting enabled by default on linux/x11

Comment 2

[:gerard-majax]

Attachment: Bug 1918538 - Remove usage of MOZ_SANDBOXED r?nika!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9b74bcc1a5a1
Remove usage of MOZ_SANDBOXED r=nika,jld

Comment 4

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/9b74bcc1a5a1