1918576 - Definite max-block-size and auto block-size shouldn't establish a percentage basis

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

nsIFrame::ComputeBSizeValueAsPercentageBasis() [1] incorrectly returns a definite percentage basis with a definite max-block-size and an auto block-size. We should only apply min-block-size & max-block-size constraint if block-size is a definite value.

[1] https://searchfox.org/mozilla-central/rev/ddd14e6b96331624d56d56b78c1d9a359d3e57d3/layout/generic/nsIFrame.cpp#6689-6712

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1909761

Comment 2

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: Bug 1918576 Part 1 - Apply min & max constraints only if block-size is definite in ComputeBSizeValueAsPercentageBasis(). r?dholbert

That is, a definite max block-size and an auto block-size should not compute a
definite percentage basis in the block axis.

Note that we accidentally pass
testing/web-platform/tests/css/css-sizing/intrinsic-percent-replaced-017.html.
After applying this patch, the test starts to fail, but it will be fixed in the
next part.

Comment 3

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: Bug 1918576 Part 2 - Mark a flex item's intrinsic inline size dirty if we override its block size. r?dholbert

In a column-oriented flex container, if a flex item's intrinsic inline size or
its descendants' inline size contributions depend on the item's block size,
NS_FRAME_DESCENDANT_INTRINSIC_ISIZE_DEPENDS_ON_BSIZE will be set. In this
case, when determining the flex item's cross-size, we need to mark the flex
item's intrinsic inline size as dirty such that its (auto) inline size is
recomputed when constructing its ReflowInput.

testing/web-platform/tests/css/css-sizing/intrinsic-percent-replaced-017.html
is the test coverage for this patch.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e8d914658c03
Part 1 - Apply min & max constraints only if block-size is definite in ComputeBSizeValueAsPercentageBasis(). r=dholbert
https://hg.mozilla.org/integration/autoland/rev/51fd81b5ced0
Part 2 - Mark a flex item's intrinsic inline size dirty if we override its block size. r=dholbert

Comment 5

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/e8d914658c03
https://hg.mozilla.org/mozilla-central/rev/51fd81b5ced0

Comment 6

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/48270 for changes under testing/web-platform/tests

Comment 7

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot