Closed Bug 1918739 Opened 4 months ago Closed 4 months ago

wgpu update 2024-09-13

Categories

(Core :: Graphics: WebGPU, task, P3)

task

Tracking

()

RESOLVED FIXED
132 Branch
Tracking Status
firefox132 --- fixed

People

(Reporter: teoxoy, Assigned: teoxoy)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

No description provided.
Assignee: nobody → ttanasoaia
Status: NEW → ASSIGNED
Pushed by jblandy@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/128de7e126a3 Update `wgpu` to revision c8beade1877251c494036fc3661b04ec6aad63a9. r=webgpu-reviewers,supply-chain-reviewers,jimb

Backed out for causing wgpu_bindings related bustages

Backout link

Push with failures

Failure log

Flags: needinfo?(ttanasoaia)

This was backed out because:

  • wgpu_bindings::server::wgpu_server_get_device_fence_handle previously—on Windows platforms—had an if statement that was conditionally compiled before a fallback return value.
  • This if was removed, leaving a block of conditionally compiled code. New control flow only returned from the block, and never proceeded to the fallback value (on Windows). rustc rightfully complains, then, about unreachable code on Windows.
  • Simple fix: Add #[cfg(not(target_os = "windows"))] on the fallback value.

Fixing myself, and queuing for landing again.

Flags: needinfo?(ttanasoaia)
Attachment #9424726 - Attachment description: Bug 1918739 - Update `wgpu` to revision c8beade1877251c494036fc3661b04ec6aad63a9. r=#webgpu-reviewers → Bug 1918739 - Update `wgpu` to revision c8beade1877251c494036fc3661b04ec6aad63a9. r=#webgpu-reviewers,#supply-chain-reviewers
Pushed by egubler@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/5060b14de618 Update `wgpu` to revision c8beade1877251c494036fc3661b04ec6aad63a9. r=webgpu-reviewers,supply-chain-reviewers,jimb
Status: ASSIGNED → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → 132 Branch

A patch has been attached on this bug, which was already closed. Filing a separate bug will ensure better tracking. If this was not by mistake and further action is needed, please alert the appropriate party. (Or: if the patch doesn't change behavior -- e.g. landing a test case, or fixing a typo -- then feel free to disregard this message)

Pushed by ttanasoaia@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/7666f8b92b88 Update doc comment for `wgpu_server_instance_request_adapter`. r=webgpu-reviewers,ErichDonGubler
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: