Closed
Bug 1918739
Opened 4 months ago
Closed 4 months ago
wgpu update 2024-09-13
Categories
(Core :: Graphics: WebGPU, task, P3)
Core
Graphics: WebGPU
Tracking
()
RESOLVED
FIXED
132 Branch
Tracking | Status | |
---|---|---|
firefox132 | --- | fixed |
People
(Reporter: teoxoy, Assigned: teoxoy)
References
(Blocks 1 open bug)
Details
Attachments
(2 files)
No description provided.
Assignee | ||
Comment 1•4 months ago
|
||
Updated•4 months ago
|
Assignee: nobody → ttanasoaia
Status: NEW → ASSIGNED
Pushed by jblandy@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/128de7e126a3
Update `wgpu` to revision c8beade1877251c494036fc3661b04ec6aad63a9. r=webgpu-reviewers,supply-chain-reviewers,jimb
Comment 3•4 months ago
|
||
Flags: needinfo?(ttanasoaia)
Comment 4•4 months ago
•
|
||
This was backed out because:
wgpu_bindings::server::wgpu_server_get_device_fence_handle
previously—on Windows platforms—had anif
statement that was conditionally compiled before a fallback return value.- This
if
was removed, leaving a block of conditionally compiled code. New control flow only returned from the block, and never proceeded to the fallback value (on Windows).rustc
rightfully complains, then, about unreachable code on Windows. - Simple fix: Add
#[cfg(not(target_os = "windows"))]
on the fallback value.
Fixing myself, and queuing for landing again.
Flags: needinfo?(ttanasoaia)
Updated•4 months ago
|
Attachment #9424726 -
Attachment description: Bug 1918739 - Update `wgpu` to revision c8beade1877251c494036fc3661b04ec6aad63a9. r=#webgpu-reviewers → Bug 1918739 - Update `wgpu` to revision c8beade1877251c494036fc3661b04ec6aad63a9. r=#webgpu-reviewers,#supply-chain-reviewers
Pushed by egubler@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5060b14de618
Update `wgpu` to revision c8beade1877251c494036fc3661b04ec6aad63a9. r=webgpu-reviewers,supply-chain-reviewers,jimb
Comment 6•4 months ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 4 months ago
status-firefox132:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 132 Branch
Assignee | ||
Comment 7•4 months ago
|
||
Comment 8•4 months ago
|
||
A patch has been attached on this bug, which was already closed. Filing a separate bug will ensure better tracking. If this was not by mistake and further action is needed, please alert the appropriate party. (Or: if the patch doesn't change behavior -- e.g. landing a test case, or fixing a typo -- then feel free to disregard this message)
Pushed by ttanasoaia@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7666f8b92b88
Update doc comment for `wgpu_server_instance_request_adapter`. r=webgpu-reviewers,ErichDonGubler
Comment 10•3 months ago
|
||
bugherder |
You need to log in
before you can comment on or make changes to this bug.
Description
•