1918739 - wgpu update 2024-09-13

Status: RESOLVED FIXED

(Core :: Graphics: WebGPU, task, P3)

Comment 1

[Teodor Tanasoaia [:teoxoy]]

Attachment: Bug 1918739 - Update `wgpu` to revision c8beade1877251c494036fc3661b04ec6aad63a9. r=#webgpu-reviewers,#supply-chain-reviewers

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/128de7e126a3
Update `wgpu` to revision c8beade1877251c494036fc3661b04ec6aad63a9. r=webgpu-reviewers,supply-chain-reviewers,jimb

Comment 3

[Norisz Fay [:noriszfay]]

Backed out for causing wgpu_bindings related bustages

Backout link

Push with failures

Failure log

Comment 4

[Erich Gubler [:ErichDonGubler]]

This was backed out because:

• wgpu_bindings::server::wgpu_server_get_device_fence_handle previously—on Windows platforms—had an if statement that was conditionally compiled before a fallback return value.
• This if was removed, leaving a block of conditionally compiled code. New control flow only returned from the block, and never proceeded to the fallback value (on Windows). rustc rightfully complains, then, about unreachable code on Windows.
• Simple fix: Add #[cfg(not(target_os = "windows"))] on the fallback value.

Fixing myself, and queuing for landing again.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5060b14de618
Update `wgpu` to revision c8beade1877251c494036fc3661b04ec6aad63a9. r=webgpu-reviewers,supply-chain-reviewers,jimb

Comment 6

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/5060b14de618

Comment 7

[Teodor Tanasoaia [:teoxoy]]

Attachment: Bug 1918739 - Update doc comment for `wgpu_server_instance_request_adapter`. r=#webgpu-reviewers

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

A patch has been attached on this bug, which was already closed. Filing a separate bug will ensure better tracking. If this was not by mistake and further action is needed, please alert the appropriate party. (Or: if the patch doesn't change behavior -- e.g. landing a test case, or fixing a typo -- then feel free to disregard this message)

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7666f8b92b88
Update doc comment for `wgpu_server_instance_request_adapter`. r=webgpu-reviewers,ErichDonGubler

Comment 10

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/7666f8b92b88