Closed Bug 1918745 Opened 1 year ago Closed 1 year ago

Add missing rollouts as test messages in NimbusRolloutMessageProvider

Categories

(Firefox :: Messaging System, task, P1)

Product:
Firefox
Component:
Messaging System
Type:
task
Points:
1

Tracking

()

Status:
RESOLVED FIXED
Milestone:
132 Branch
Iteration:
132.2 - Sep 16 - Sep 27
Tracking Flags:
Tracking Status
firefox132 --- fixed

People

(Reporter: nsauermann, Assigned: nsauermann)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Bug 1918745 - Adds 'FOX_DOODLE_SET_DEFAULT' and 'FAKESPOT_CALLOUT_' rollouts as test messages in NimbusRolloutMessageProvider
48 bytes, text/x-phabricator-request
Details | Review

Adds FOX_DOODLE_SET_DEFAULT and FAKESPOT_CALLOUT_ and removes Q4_DEVICE_MIGRATION and ADDONS_STAFF_PICK as part of live rollouts.

Processing rollout: 1-click-set-to-default-existing-profiles-rollout
  Processing branch: treatment-b
    Importing message: FOX_DOODLE_SET_DEFAULT
Processing rollout: us-review-checker-rollout-v2
  Processing branch: treatment-a
    Importing message 1 of 4: FAKESPOT_CALLOUT_NO_OP_DUMMY
    Importing message 2 of 4: FAKESPOT_CALLOUT_CLOSED_NOT_OPTED_IN_AUTO_OPEN
    Importing message 3 of 4: FAKESPOT_CALLOUT_PDP_NOT_OPTED_IN_REMINDER
    Importing message 4 of 4: FAKESPOT_CALLOUT_OPTED_OUT_SURVEY
Processing rollout: recommend-add-ons-staff-pick-relaunch-treatment-a-rollout
Assignee: nobody → nsauermann
Status: NEW → ASSIGNED
Summary: Add FOX_DOODLE_SET_DEFAULT and FAKESPOT_CALLOUT rollouts as test messages in NimbusRolloutMessageProvider → Add missing rollouts as test messages in NimbusRolloutMessageProvider
Iteration: --- → 132.2 - Sep 16 - Sep 27
Priority: -- → P1
Points: --- → 1
Attachment #9424719 - Attachment description: Bug 1918745 - Adds 'FOX_DOODLE_SET_DEFAULT', 'ADDONS_STAFF_PICK' and 'FAKESPOT_CALLOUT_' rollouts as test messages in NimbusRolloutMessageProvider → Bug 1918745 - Adds 'FOX_DOODLE_SET_DEFAULT' and 'FAKESPOT_CALLOUT_' rollouts as test messages in NimbusRolloutMessageProvider
Pushed by nsauermann@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/8faf0e38aae6 Adds 'FOX_DOODLE_SET_DEFAULT' and 'FAKESPOT_CALLOUT_' rollouts as test messages in NimbusRolloutMessageProvider r=omc-reviewers,pdahiya

Backed out for causing xpcshell failures on test_NimbusRolloutMessageProvider.js.

[task 2024-09-16T18:56:27.546Z] 18:56:27     INFO -  TEST-START | browser/components/asrouter/tests/xpcshell/test_NimbusRolloutMessageProvider.js
[task 2024-09-16T18:56:29.340Z] 18:56:29  WARNING -  TEST-UNEXPECTED-FAIL | browser/components/asrouter/tests/xpcshell/test_NimbusRolloutMessageProvider.js | xpcshell return code: 0
[task 2024-09-16T18:56:29.344Z] 18:56:29     INFO -  TEST-INFO took 1794ms
[task 2024-09-16T18:56:29.345Z] 18:56:29     INFO -  >>>>>>>
[task 2024-09-16T18:56:29.345Z] 18:56:29     INFO -  (xpcshell/head.js) | test MAIN run_test pending (1)
[task 2024-09-16T18:56:29.345Z] 18:56:29     INFO -  (xpcshell/head.js) | test run_next_test 0 pending (2)
[task 2024-09-16T18:56:29.345Z] 18:56:29     INFO -  (xpcshell/head.js) | test MAIN run_test finished (2)
[task 2024-09-16T18:56:29.345Z] 18:56:29     INFO -  running event loop
[task 2024-09-16T18:56:29.345Z] 18:56:29     INFO -  browser/components/asrouter/tests/xpcshell/test_NimbusRolloutMessageProvider.js | Starting setup setup
[task 2024-09-16T18:56:29.345Z] 18:56:29     INFO -  (xpcshell/head.js) | test setup pending (2)
[task 2024-09-16T18:56:29.345Z] 18:56:29     INFO -  PID 20794 | URI: chrome://browser/content/asrouter/schemas/MessagingExperiment.schema.json
[task 2024-09-16T18:56:29.345Z] 18:56:29     INFO -  (xpcshell/head.js) | test run_next_test 0 finished (2)
[task 2024-09-16T18:56:29.346Z] 18:56:29     INFO -  PID 20794 | URI: resource://testing-common/BookmarksBarButton.schema.json
[task 2024-09-16T18:56:29.346Z] 18:56:29     INFO -  PID 20794 | URI: resource://testing-common/FxMSCommon.schema.json
[task 2024-09-16T18:56:29.346Z] 18:56:29     INFO -  PID 20794 | URI: resource://testing-common/ExtensionDoorhanger.schema.json
[task 2024-09-16T18:56:29.346Z] 18:56:29     INFO -  PID 20794 | URI: resource://testing-common/FxMSCommon.schema.json
[task 2024-09-16T18:56:29.346Z] 18:56:29     INFO -  PID 20794 | URI: resource://testing-common/CFRUrlbarChiclet.schema.json
[task 2024-09-16T18:56:29.346Z] 18:56:29     INFO -  PID 20794 | URI: resource://testing-common/FxMSCommon.schema.json
[task 2024-09-16T18:56:29.346Z] 18:56:29     INFO -  PID 20794 | URI: resource://testing-common/InfoBar.schema.json
[task 2024-09-16T18:56:29.346Z] 18:56:29     INFO -  PID 20794 | URI: resource://testing-common/FxMSCommon.schema.json
[task 2024-09-16T18:56:29.346Z] 18:56:29     INFO -  PID 20794 | URI: resource://testing-common/NewtabPromoMessage.schema.json
[task 2024-09-16T18:56:29.346Z] 18:56:29     INFO -  PID 20794 | URI: resource://testing-common/FxMSCommon.schema.json
[task 2024-09-16T18:56:29.346Z] 18:56:29     INFO -  PID 20794 | URI: resource://testing-common/Spotlight.schema.json
[task 2024-09-16T18:56:29.346Z] 18:56:29     INFO -  PID 20794 | URI: resource://testing-common/FxMSCommon.schema.json
[task 2024-09-16T18:56:29.346Z] 18:56:29     INFO -  PID 20794 | URI: resource://testing-common/ToastNotification.schema.json
[task 2024-09-16T18:56:29.346Z] 18:56:29     INFO -  PID 20794 | URI: resource://testing-common/FxMSCommon.schema.json
[task 2024-09-16T18:56:29.346Z] 18:56:29     INFO -  PID 20794 | URI: resource://testing-common/ToolbarBadgeMessage.schema.json
[task 2024-09-16T18:56:29.347Z] 18:56:29     INFO -  PID 20794 | URI: resource://testing-common/FxMSCommon.schema.json
[task 2024-09-16T18:56:29.347Z] 18:56:29     INFO -  PID 20794 | URI: resource://testing-common/UpdateAction.schema.json
[task 2024-09-16T18:56:29.347Z] 18:56:29     INFO -  PID 20794 | URI: resource://testing-common/FxMSCommon.schema.json
[task 2024-09-16T18:56:29.347Z] 18:56:29     INFO -  PID 20794 | URI: resource://testing-common/Spotlight.schema.json
[task 2024-09-16T18:56:29.347Z] 18:56:29     INFO -  PID 20794 | URI: resource://testing-common/FxMSCommon.schema.json
[task 2024-09-16T18:56:29.347Z] 18:56:29     INFO -  (xpcshell/head.js) | test run_next_test 1 pending (2)
[task 2024-09-16T18:56:29.347Z] 18:56:29     INFO -  (xpcshell/head.js) | test setup finished (2)
[task 2024-09-16T18:56:29.347Z] 18:56:29     INFO -  browser/components/asrouter/tests/xpcshell/test_NimbusRolloutMessageProvider.js | Starting test_NimbusRolloutMessageProvider
[task 2024-09-16T18:56:29.347Z] 18:56:29     INFO -  (xpcshell/head.js) | test test_NimbusRolloutMessageProvider pending (2)
[task 2024-09-16T18:56:29.347Z] 18:56:29     INFO -  TEST-PASS | browser/components/asrouter/tests/xpcshell/test_NimbusRolloutMessageProvider.js | test_NimbusRolloutMessageProvider - [test_NimbusRolloutMessageProvider : 23] Schema validator found for spotlight - true == true
[task 2024-09-16T18:56:29.347Z] 18:56:29     INFO -  TEST-PASS | browser/components/asrouter/tests/xpcshell/test_NimbusRolloutMessageProvider.js | test_NimbusRolloutMessageProvider - [test_NimbusRolloutMessageProvider : 30] Message FOX_DOODLE_SET_DEFAULT validates as spotlight template - errors = [] - true == true
[task 2024-09-16T18:56:29.347Z] 18:56:29     INFO -  TEST-PASS | browser/components/asrouter/tests/xpcshell/test_NimbusRolloutMessageProvider.js | test_NimbusRolloutMessageProvider - [test_NimbusRolloutMessageProvider : 35] Message FOX_DOODLE_SET_DEFAULT validates as a MessagingExperiment - errors = [] - true == true
[task 2024-09-16T18:56:29.347Z] 18:56:29  WARNING -  TEST-UNEXPECTED-FAIL | browser/components/asrouter/tests/xpcshell/test_NimbusRolloutMessageProvider.js | test_NimbusRolloutMessageProvider - [test_NimbusRolloutMessageProvider : 23] No schema validator found for template undefined. Please update this test to add one. - false == true
[task 2024-09-16T18:56:29.347Z] 18:56:29     INFO -  /builds/worker/workspace/build/tests/xpcshell/tests/browser/components/asrouter/tests/xpcshell/test_NimbusRolloutMessageProvider.js:test_NimbusRolloutMessageProvider:23
[task 2024-09-16T18:56:29.348Z] 18:56:29     INFO -  /builds/worker/workspace/build/tests/xpcshell/head.js:_run_next_test/<:1759
[task 2024-09-16T18:56:29.348Z] 18:56:29     INFO -  /builds/worker/workspace/build/tests/xpcshell/head.js:_run_next_test:1759
[task 2024-09-16T18:56:29.348Z] 18:56:29     INFO -  /builds/worker/workspace/build/tests/xpcshell/head.js:run:808
[task 2024-09-16T18:56:29.348Z] 18:56:29     INFO -  /builds/worker/workspace/build/tests/xpcshell/head.js:_do_main:245
[task 2024-09-16T18:56:29.348Z] 18:56:29     INFO -  /builds/worker/workspace/build/tests/xpcshell/head.js:_execute_test:596
[task 2024-09-16T18:56:29.348Z] 18:56:29     INFO -  -e:null:1
[task 2024-09-16T18:56:29.348Z] 18:56:29     INFO -  exiting test
[task 2024-09-16T18:56:29.348Z] 18:56:29     INFO -  (xpcshell/head.js) | test run_next_test 1 finished (2)
[task 2024-09-16T18:56:29.348Z] 18:56:29     INFO -  Unexpected exception NS_ERROR_ABORT:
[task 2024-09-16T18:56:29.348Z] 18:56:29     INFO -  _abort_failed_test@/builds/worker/workspace/build/tests/xpcshell/head.js:869:20
[task 2024-09-16T18:56:29.348Z] 18:56:29     INFO -  do_report_result@/builds/worker/workspace/build/tests/xpcshell/head.js:981:5
[task 2024-09-16T18:56:29.348Z] 18:56:29     INFO -  Assert<@/builds/worker/workspace/build/tests/xpcshell/head.js:70:21
[task 2024-09-16T18:56:29.348Z] 18:56:29     INFO -  Assert.prototype.report@resource://testing-common/Assert.sys.mjs:251:10
[task 2024-09-16T18:56:29.348Z] 18:56:29     INFO -  Assert.prototype.ok@resource://testing-common/Assert.sys.mjs:277:10
[task 2024-09-16T18:56:29.348Z] 18:56:29     INFO -  test_NimbusRolloutMessageProvider@/builds/worker/workspace/build/tests/xpcshell/tests/browser/components/asrouter/tests/xpcshell/test_NimbusRolloutMessageProvider.js:23:12
[task 2024-09-16T18:56:29.348Z] 18:56:29     INFO -  _run_next_test/<@/builds/worker/workspace/build/tests/xpcshell/head.js:1759:22
[task 2024-09-16T18:56:29.349Z] 18:56:29     INFO -  _run_next_test@/builds/worker/workspace/build/tests/xpcshell/head.js:1759:38
[task 2024-09-16T18:56:29.349Z] 18:56:29     INFO -  run@/builds/worker/workspace/build/tests/xpcshell/head.js:808:9
[task 2024-09-16T18:56:29.349Z] 18:56:29     INFO -  _do_main@/builds/worker/workspace/build/tests/xpcshell/head.js:245:6
[task 2024-09-16T18:56:29.349Z] 18:56:29     INFO -  _execute_test@/builds/worker/workspace/build/tests/xpcshell/head.js:596:5
[task 2024-09-16T18:56:29.349Z] 18:56:29     INFO -  @-e:1:1
[task 2024-09-16T18:56:29.349Z] 18:56:29     INFO -  exiting test
[task 2024-09-16T18:56:29.349Z] 18:56:29     INFO -  <<<<<<<
[task 2024-09-16T18:56:29.349Z] 18:56:29     INFO -  INFO | Result summary:
[task 2024-09-16T18:56:29.349Z] 18:56:29     INFO -  INFO | Passed: 207
[task 2024-09-16T18:56:29.349Z] 18:56:29  WARNING -  INFO | Failed: 1
[task 2024-09-16T18:56:29.349Z] 18:56:29  WARNING -  One or more unittests failed.
[task 2024-09-16T18:56:29.349Z] 18:56:29     INFO -  INFO | Todo: 0
[task 2024-09-16T18:56:29.349Z] 18:56:29     INFO -  INFO | Retried: 1
[task 2024-09-16T18:56:29.349Z] 18:56:29     INFO -  SUITE-END | took 221s
[task 2024-09-16T18:56:29.349Z] 18:56:29     INFO -  Node moz-http2 server shutting down ...
[task 2024-09-16T18:56:29.350Z] 18:56:29     INFO -  http3Server server shutting down ...
[task 2024-09-16T18:56:29.485Z] 18:56:29     INFO - Return code: 1
[task 2024-09-16T18:56:29.485Z] 18:56:29     INFO - TinderboxPrint: xpcshell-xpcshell<br/>207/<em class="testfail">1</em>/0
[task 2024-09-16T18:56:29.485Z] 18:56:29  WARNING - setting return code to 2
[task 2024-09-16T18:56:29.485Z] 18:56:29     INFO - The xpcshell suite: xpcshell ran with return status: FAILURE
Flags: needinfo?(nsauermann)

Sorry about that, looks like FAKESPOT_CALLOUT_NO_OP_DUMMY was missing a template.

Flags: needinfo?(nsauermann)
Severity: -- → S3
Pushed by nsauermann@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/bcc87413368b Adds 'FOX_DOODLE_SET_DEFAULT' and 'FAKESPOT_CALLOUT_' rollouts as test messages in NimbusRolloutMessageProvider r=omc-reviewers,pdahiya

https://hg.mozilla.org/mozilla-central/rev/bcc87413368b

Status: ASSIGNED → RESOLVED
Closed: 1 year ago
status-firefox132: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 132 Branch
Blocks: fxms-infra
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: