Closed Bug 1918746 Opened 2 months ago Closed 1 month ago

applyConstraints on desktop capture tracks that use a system picker brings the picker up again

Categories

(Core :: WebRTC: Audio/Video, defect, P1)

defect

Tracking

()

RESOLVED FIXED
132 Branch
Tracking Status
firefox-esr115 --- unaffected
firefox-esr128 --- unaffected
firefox130 --- unaffected
firefox131 --- unaffected
firefox132 --- fixed

People

(Reporter: pehrsons, Assigned: pehrsons)

References

(Blocks 2 open bugs, Regression)

Details

(Keywords: regression)

Attachments

(1 file)

No description provided.

Set release status flags based on info from the regressing bug 1918096

Already today we reconfigure capturers without stopping them in cases where they
are shared between multiple gUM/gDM requests: We find the device capability
(for cameras) that satisfies all the requested capabilities (downscaling, frame
dropping allowed) and call StartCapture again with that.

Thus, there is no concern about camera backends not supporting this call
sequence.

Desktop capture backends have a simpler API (only Start, for Stop they have to
be destroyed) and are not actually re-started. Resolution is always captured in
full and frame rate is controlled by the timer that triggers CaptureFrame().

This patch makes content processes not request capture to be stopped when
updating their requested capability. This means the path described above will be
exercised more. This also brings with it some invariants that no longer hold,
but are handled explicitly instead: capabilities for a captureId may now be
updated on the fly, without prior removal.

Blocks: 1854382, pipewire
OS: macOS → Unspecified
Summary: applyConstraints on desktop capture track on macOS 15 brings up the system picker → applyConstraints on desktop capture tracks that use a system picker brings the picker up again
Pushed by pehrsons@gmail.com: https://hg.mozilla.org/integration/autoland/rev/8f95af75879a Don't stop video capturers before reconfiguring them. r=grulja,webrtc-reviewers,jib
Status: ASSIGNED → RESOLVED
Closed: 1 month ago
Resolution: --- → FIXED
Target Milestone: --- → 132 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: