191891 - [hang] clicking in the Junk Log (or Filter Log) window then typing causes app to hang.

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Message Display, defect)

Description

[esther]

Using trunk build 20020203 on winxp and linux (haven't tested mac osx yet) if
you open the Junk Log, mouse click in the text display area and start typing the
app will hang.  For windows you will get the app not responding message and you
have to close the app from this error dialog.  With linux you have to close the
terminal window. I'm not getting a talkback report with this hang. 

1. Launch app
2. Open mail and then open Junk Mail Control via the menu
2. Mouse click in the text display area (doesn't matter if you have data in that
window or not) start typing.

Result: app hangs
Expected: nothing to happen since that area is not an text entry field.

Comment 1

[esther]

nominating, we shouldn't hang the app.  I lost data, I had been using the editor
to update test cases and could not recover. 

Comment 2

[laurel]

There's already a known crasher on Mac  -- see bug 188974

Comment 3

[esther]

This is not the same as 188974.  I read through that bug before I logged this
one. I don't crash or hang turning on the Junk Log or opening and closing the
Junk Log window over and over again or even just clicking in the display area of
the Junk Log. I only hang when I start hitting the keyboard after focusing that
area.  However, because of 188974 I won't be able to test this bug on that platform.

Comment 4

[Samir Gehani]

Mail triage team: nsbeta1+/adt3

Comment 5

[jglick]

 It would also be useful if the Junk Log dialog didn't look like a field that
can be edited.
http://www.mozilla.org/mailnews/specs/spam/images/Spam2.gif

Comment 6

[Samir Gehani]

Mail triage team: nsbeta1+/adt2

Comment 7

[(not reading, please use [e-mail] instead)]

I broke, and we appear to be hung in typeahead find.

nsCOMTypeInfo<nsISimpleEnumerator>::GetIID() line 243 + 8 bytes
nsCOMPtr<nsISimpleEnumerator>::nsCOMPtr<nsISimpleEnumerator>(const
nsQueryInterface & {...}) line 572 + 5 bytes
nsCOMPtr<nsISimpleEnumerator>::Assert_NoQueryNeeded() line 508
nsGetterAddRefs<nsISimpleEnumerator>::~nsGetterAddRefs<nsISimpleEnumerator>()
line 1072
nsTypeAheadFind::FindItNow(nsIPresShell * 0x00000000, int 0, int 1, int 1) line 1348
nsTypeAheadFind::HandleChar(unsigned short 115) line 907 + 45 bytes
nsTypeAheadFind::KeyPress(nsTypeAheadFind * const 0x00faa9ec, nsIDOMEvent *
0x04c7f150) line 688 + 16 bytes
nsEventListenerManager::HandleEvent(nsEventListenerManager * const 0x04bc87d8,
nsIPresContext * 0x04c7ce50, nsEvent * 0x0012c174, nsIDOMEvent * * 0x0012bde4,
nsIDOMEventTarget * 0x04bc8930, unsigned int 2, nsEventStatus * 0x0012bfac) line
1657 + 41 bytes
nsWindowRoot::HandleChromeEvent(nsWindowRoot * const 0x04bc8938, nsIPresContext
* 0x04c7ce50, nsEvent * 0x0012c174, nsIDOMEvent * * 0x0012bde4, unsigned int 2,
nsEventStatus * 0x0012bfac) line 215
GlobalWindowImpl::HandleDOMEvent(GlobalWindowImpl * const 0x04bc8628,
nsIPresContext * 0x04c7ce50, nsEvent * 0x0012c174, nsIDOMEvent * * 0x0012bde4,
unsigned int 2, nsEventStatus * 0x0012bfac) line 828
nsXULDocument::HandleDOMEvent(nsXULDocument * const 0x04bf7fe0, nsIPresContext *
0x04c7ce50, nsEvent * 0x0012c174, nsIDOMEvent * * 0x0012bde4, unsigned int 2,
nsEventStatus * 0x0012bfac) line 2586
nsXULElement::HandleDOMEvent(nsXULElement * const 0x04bf7600, nsIPresContext *
0x04c7ce50, nsEvent * 0x0012c174, nsIDOMEvent * * 0x0012bde4, unsigned int 2,
nsEventStatus * 0x0012bfac) line 3359 + 47 bytes
nsXULElement::HandleDOMEvent(nsXULElement * const 0x04c12fe0, nsIPresContext *
0x04c7ce50, nsEvent * 0x0012c174, nsIDOMEvent * * 0x0012bde4, unsigned int 2,
nsEventStatus * 0x0012bfac) line 3353 + 61 bytes
nsXULElement::HandleDOMEvent(nsXULElement * const 0x04bfde60, nsIPresContext *
0x04c7ce50, nsEvent * 0x0012c174, nsIDOMEvent * * 0x0012bde4, unsigned int 2,
nsEventStatus * 0x0012bfac) line 3353 + 61 bytes
nsXULElement::HandleDOMEvent(nsXULElement * const 0x04c03b68, nsIPresContext *
0x04c7ce50, nsEvent * 0x0012c174, nsIDOMEvent * * 0x0012bde4, unsigned int 2,
nsEventStatus * 0x0012bfac) line 3353 + 61 bytes
nsXULElement::HandleDOMEvent(nsXULElement * const 0x04c03c58, nsIPresContext *
0x04c7ce50, nsEvent * 0x0012c174, nsIDOMEvent * * 0x0012bde4, unsigned int 2,
nsEventStatus * 0x0012bfac) line 3353 + 61 bytes
nsXULElement::HandleDOMEvent(nsXULElement * const 0x04c03e18, nsIPresContext *
0x04c7ce50, nsEvent * 0x0012c174, nsIDOMEvent * * 0x0012bde4, unsigned int 2,
nsEventStatus * 0x0012bfac) line 3353 + 61 bytes
nsXULElement::HandleChromeEvent(nsXULElement * const 0x04c03e24, nsIPresContext
* 0x04c7ce50, nsEvent * 0x0012c174, nsIDOMEvent * * 0x0012bde4, unsigned int 2,
nsEventStatus * 0x0012bfac) line 4475 + 39 bytes
GlobalWindowImpl::HandleDOMEvent(GlobalWindowImpl * const 0x04c3abf8,
nsIPresContext * 0x04c7ce50, nsEvent * 0x0012c174, nsIDOMEvent * * 0x0012bde4,
unsigned int 2, nsEventStatus * 0x0012bfac) line 828
nsDocument::HandleDOMEvent(nsDocument * const 0x04bf6b10, nsIPresContext *
0x04c7ce50, nsEvent * 0x0012c174, nsIDOMEvent * * 0x0012bde4, unsigned int 2,
nsEventStatus * 0x0012bfac) line 3472
nsGenericElement::HandleDOMEvent(nsGenericElement * const 0x04c7c218,
nsIPresContext * 0x04c7ce50, nsEvent * 0x0012c174, nsIDOMEvent * * 0x0012bde4,
unsigned int 7, nsEventStatus * 0x0012bfac) line 1965 + 47 bytes
PresShell::HandleEventInternal(nsEvent * 0x0012c174, nsIView * 0x04befef0,
unsigned int 1, nsEventStatus * 0x0012bfac) line 6226 + 47 bytes
PresShell::HandleEvent(PresShell * const 0x04c7d8dc, nsIView * 0x04befef0,
nsGUIEvent * 0x0012c174, nsEventStatus * 0x0012bfac, int 1, int & 1) line 6150 +
25 bytes
nsViewManager::HandleEvent(nsView * 0x04befef0, nsGUIEvent * 0x0012c174, int 0)
line 2162
nsView::HandleEvent(nsViewManager * 0x04be1cd8, nsGUIEvent * 0x0012c174, int 0)
line 309
nsViewManager::DispatchEvent(nsViewManager * const 0x04be1cd8, nsGUIEvent *
0x0012c174, nsEventStatus * 0x0012c0e4) line 1938 + 23 bytes
HandleEvent(nsGUIEvent * 0x0012c174) line 83
nsWindow::DispatchEvent(nsWindow * const 0x04be18ac, nsGUIEvent * 0x0012c174,
nsEventStatus & nsEventStatus_eIgnore) line 1147 + 10 bytes
nsWindow::DispatchWindowEvent(nsGUIEvent * 0x0012c174) line 1168
nsWindow::DispatchKeyEvent(unsigned int 131, unsigned short 115, unsigned int 0,
long 0) line 3047 + 15 bytes
nsWindow::OnChar(unsigned int 115, unsigned int 0, unsigned char 0) line 3242
nsWindow::ProcessMessage(unsigned int 258, unsigned int 115, long 2031617, long
* 0x0012c610) line 3953 + 41 bytes
nsWindow::WindowProc(HWND__ * 0x005e019c, unsigned int 258, unsigned int 115,
long 2031617) line 1434 + 27 bytes
USER32! 77e3a290()
USER32! 77e145b1()
USER32! 77e1a752()
nsXULWindow::ShowModal(nsXULWindow * const 0x04bc7710) line 299
nsWebShellWindow::ShowModal(nsWebShellWindow * const 0x04bc7710) line 1106
nsContentTreeOwner::ShowAsModal(nsContentTreeOwner * const 0x04bd8264) line 447
nsWindowWatcher::OpenWindowJS(nsWindowWatcher * const 0x00fbe434, nsIDOMWindow *
0x046f37c4, const char * 0x04bc5000, const char * 0x0012ccc4, const char *
0x0012cd14, int 1, unsigned int 1, long * 0x04bc532c, nsIDOMWindow * *
0x0012cd60) line 790
GlobalWindowImpl::OpenInternal(GlobalWindowImpl * const 0x046f37c0, const
nsAString & {...}, const nsAString & {...}, const nsAString & {...}, int 1, long
* 0x04bc5320, unsigned int 4, nsISupports * 0x00000000, nsIDOMWindow * *
0x0012d12c) line 4387 + 141 bytes
GlobalWindowImpl::OpenDialog(GlobalWindowImpl * const 0x046f37c8, nsIDOMWindow *
* 0x0012d12c) line 3070 + 59 bytes
XPTC_InvokeByIndex(nsISupports * 0x046f37c8, unsigned int 16, unsigned int 1,
nsXPTCVariant * 0x0012d12c) line 102
XPCWrappedNative::CallMethod(XPCCallContext & {...}, XPCWrappedNative::CallMode
CALL_METHOD) line 2023 + 42 bytes
XPC_WN_CallMethod(JSContext * 0x048a6970, JSObject * 0x03e70248, unsigned int 4,
long * 0x04bc5320, long * 0x0012d408) line 1292 + 14 bytes
js_Invoke(JSContext * 0x048a6970, unsigned int 4, unsigned int 0) line 843 + 23
bytes
js_Interpret(JSContext * 0x048a6970, long * 0x0012e2c8) line 2811 + 15 bytes
js_Invoke(JSContext * 0x048a6970, unsigned int 1, unsigned int 2) line 860 + 13
bytes
js_InternalInvoke(JSContext * 0x048a6970, JSObject * 0x0470f3b8, long 76151120,
unsigned int 0, unsigned int 1, long * 0x0012e524, long * 0x0012e3f4) line 935 +
20 bytes
JS_CallFunctionValue(JSContext * 0x048a6970, JSObject * 0x0470f3b8, long
76151120, unsigned int 1, long * 0x0012e524, long * 0x0012e3f4) line 3432 + 31 bytes
nsJSContext::CallEventHandler(nsJSContext * const 0x048a68f8, void * 0x0470f3b8,
void * 0x0489f950, unsigned int 1, void * 0x0012e524, int * 0x0012e528, int 0)
line 1040 + 33 bytes
nsJSEventListener::HandleEvent(nsJSEventListener * const 0x04a46f08, nsIDOMEvent
* 0x04bc3c88) line 181 + 77 bytes
nsEventListenerManager::HandleEventSubType(nsListenerStruct * 0x046f6980,
nsIDOMEvent * 0x04bc3c88, nsIDOMEventTarget * 0x04bc3dc8, unsigned int 8,
unsigned int 7) line 1217 + 20 bytes
nsEventListenerManager::HandleEvent(nsEventListenerManager * const 0x04a46e90,
nsIPresContext * 0x0494eaf8, nsEvent * 0x0012f004, nsIDOMEvent * * 0x0012eeb8,
nsIDOMEventTarget * 0x04bc3dc8, unsigned int 7, nsEventStatus * 0x0012f04c) line
2216 + 36 bytes
nsXULElement::HandleDOMEvent(nsXULElement * const 0x04a46e18, nsIPresContext *
0x0494eaf8, nsEvent * 0x0012f004, nsIDOMEvent * * 0x0012eeb8, unsigned int 7,
nsEventStatus * 0x0012f04c) line 3336
PresShell::HandleDOMEventWithTarget(PresShell * const 0x049322c0, nsIContent *
0x04a46e18, nsEvent * 0x0012f004, nsEventStatus * 0x0012f04c) line 6289 + 39 bytes
nsButtonBoxFrame::MouseClicked(nsIPresContext * 0x0494eaf8, nsGUIEvent *
0x0012f20c) line 200
nsButtonBoxFrame::HandleEvent(nsButtonBoxFrame * const 0x04adc810,
nsIPresContext * 0x0494eaf8, nsGUIEvent * 0x0012f20c, nsEventStatus *
0x0012f5a0) line 147
PresShell::HandleEventInternal(nsEvent * 0x0012f20c, nsIView * 0x00000000,
unsigned int 1, nsEventStatus * 0x0012f5a0) line 6257 + 38 bytes
PresShell::HandleEventWithTarget(PresShell * const 0x049322c0, nsEvent *
0x0012f20c, nsIFrame * 0x04adc810, nsIContent * 0x04a46e18, unsigned int 1,
nsEventStatus * 0x0012f5a0) line 6195 + 22 bytes
nsEventStateManager::CheckForAndDispatchClick(nsIPresContext * 0x0494eaf8,
nsMouseEvent * 0x0012f7a8, nsEventStatus * 0x0012f5a0) line 2850 + 66 bytes
nsEventStateManager::PostHandleEvent(nsEventStateManager * const 0x0489d918,
nsIPresContext * 0x0494eaf8, nsEvent * 0x0012f7a8, nsIFrame * 0x04adc810,
nsEventStatus * 0x0012f5a0, nsIView * 0x0494ab98) line 1847 + 23 bytes
PresShell::HandleEventInternal(nsEvent * 0x0012f7a8, nsIView * 0x0494ab98,
unsigned int 1, nsEventStatus * 0x0012f5a0) line 6262 + 43 bytes
PresShell::HandleEvent(PresShell * const 0x049322c4, nsIView * 0x0494ab98,
nsGUIEvent * 0x0012f7a8, nsEventStatus * 0x0012f5a0, int 1, int & 1) line 6150 +
25 bytes
nsViewManager::HandleEvent(nsView * 0x0494ab98, nsGUIEvent * 0x0012f7a8, int 1)
line 2208
nsView::HandleEvent(nsViewManager * 0x0494a958, nsGUIEvent * 0x0012f7a8, int 1)
line 309
nsViewManager::DispatchEvent(nsViewManager * const 0x0494a958, nsGUIEvent *
0x0012f7a8, nsEventStatus * 0x0012f6a4) line 1938 + 23 bytes
HandleEvent(nsGUIEvent * 0x0012f7a8) line 83
nsWindow::DispatchEvent(nsWindow * const 0x0494ac44, nsGUIEvent * 0x0012f7a8,
nsEventStatus & nsEventStatus_eIgnore) line 1147 + 10 bytes
nsWindow::DispatchWindowEvent(nsGUIEvent * 0x0012f7a8) line 1168
nsWindow::DispatchMouseEvent(unsigned int 301, unsigned int 0, nsPoint *
0x00000000) line 5406 + 21 bytes
ChildWindow::DispatchMouseEvent(unsigned int 301, unsigned int 0, nsPoint *
0x00000000) line 5663
nsWindow::ProcessMessage(unsigned int 514, unsigned int 0, long 787074, long *
0x0012fc38) line 4118 + 28 bytes
nsWindow::WindowProc(HWND__ * 0x00e001ac, unsigned int 514, unsigned int 0, long
787074) line 1434 + 27 bytes
USER32! 77e3a290()
USER32! 77e145b1()
USER32! 77e1a752()
nsAppShellService::Run(nsAppShellService * const 0x00fa2d88) line 480
main1(int 2, char * * 0x00270030, nsISupports * 0x00f98f40) line 1273 + 32 bytes
main(int 2, char * * 0x00270030) line 1636 + 37 bytes
mainCRTStartup() line 338 + 17 bytes
KERNEL32! 77e9ca90()

note, the log is implemented with a browser tag.

<browser id="logView" disablehistory="true" disablesecurity="true"
src="about:blank" flex="1"/>

adding autofind="false" fixes the problem.  I'll check with aaronl if that's the
right thing, or if this is a bug in the typeahead find code that needs to be fixed.

about making the junk log look "disabled", I'll spin that off to another bug.

Comment 8

[(not reading, please use [e-mail] instead)]

Attachment: patch

Comment 9

[(not reading, please use [e-mail] instead)]

Comment on attachment 115656 [details] [diff] [review]
patch

aaron, can you review, or let me know if this is really a bigger problem?

Comment 10

[Aaron Leventhal]

Comment on attachment 115656 [details] [diff] [review]
patch

That's a good fix, but I'm not sure why it would hang in typeaheadfind. I
haven't seen that anywhere else. Do you have details on why it's in an infinite
loop?

Comment 11

[(not reading, please use [e-mail] instead)]

fixed.

thanks for the review, aaron.

I haven't figured out the hang yet.
  
I'll log a new bug to track it, with steps on how to reproduce it.

asa, this is a low risk fix for a hang bug.  I think we want it for 1.3 final.

Comment 12

[(not reading, please use [e-mail] instead)]

great job to esther for finding this one.

Comment 13

[(not reading, please use [e-mail] instead)]

hang bug spun out to bug #195243 (assigned to aaronl)
make log look disabled spun out to bug #195244 

Comment 14

[Asa Dotzler [:asa]]

Comment on attachment 115656 [details] [diff] [review]
patch

Yes, let's get this into the 1.3 branch. 
a=asa (on behalf of drivers) for checkin to the 1.3 branch.

Comment 15

[(not reading, please use [e-mail] instead)]

backported to the 1.3 final branch, so updating target milestone.

Comment 16

[esther]

Using trunk build 20030228 on winxp, mac osx and linux this is fixed and verified.