1918942 - Settings -> Search -> Default Search Engine dropdown menu contains ellipse

Status: VERIFIED FIXED

(Firefox :: Settings UI, defect, P1)

Description

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

Filed per bug 1735589 Comment 19.

Steps to reproduce:

1. Open Settings -> Search.
2. Observe the "Default Search Engine" drop down menu.

Expected results:
The "Default Search Engine" drop down menu displays full text like "Google".

Actual results:
The dropmarker's width is larger that it used to be (17px). It was 12px. This makes "Default Search Engine" drop down menu contains ellipse, such as "Goo...". See https://bugzilla.mozilla.org/attachment.cgi?id=9424866

Some observations:
After my patch in bug 1735589, when a flex item gets its cross-size stretched to the flex container's cross-size, it will try to honor the image's aspect-ratio, and its cross-size (height) will transfer to its main-size (width). It appears that other dropmarkers (e.g. Settings -> General -> Default Zoom, and many others) are not affected, but I don't have enough knowledge to reason why only the Default Search Engine dropdown menu is affected.

A reasonable fix would be adding align-self: center to dropmarker, so its cross-size (height) won’t be stretched while keeping the icon centered vertically in its parent flex container.

Comment 1

[Alice0775 White]

Attachment: Advanced fonts dialog

Size drop down are also affected in Advanced fonts dialog

Comment 2

[Alice0775 White]

Attachment: Number of rows

Number of rows are also affected.

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1735589

Comment 4

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

Attachment: Bug 1918942 - Make dropmarker center aligned in the cross-axis.

See bug 1918942 for an analysis. This patch prevents dropmarker's cross-size
from being stretched, restoring its size to the content size of
arrow-down-12.svg (12px x 12px).

Comment 5

[Itiel]

(In reply to Ting-Yu Lin [:TYLin] (PDT, UTC-7) from comment #0)

... but I don't have enough knowledge to reason why only the Default Search Engine dropdown menu is affected.

It seems that the differentiator is whether align="center" is set on the menulist's markup or not.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/83fe0879b153
Make dropmarker center aligned in the cross-axis. r=desktop-theme-reviewers,emilio,dao

Comment 7

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/83fe0879b153

Comment 8

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

Reproducible on a 2024-09-15 Firefox Nightly build on Windows 10.
Issue is verified as fixed on Firefox 132.0b2 and Firefox Nightly 133.0a1 on Windows 10, Ubuntu 22, macOS 14.