1919031 - www.facebook.com - Meatball menu from posts does not work

Status: VERIFIED FIXED

(Web Compatibility :: Site Reports, defect, P1)

Description

[Calin Tanase]

Environment:
Operating system: Android 10
Firefox version: Firefox Nightly 132.0a1-20240913100931 / Firefox Release 130.0-20240829075237

Preconditions:

• Clean profile

Steps to reproduce:

1. Go to https://www.facebook.com
2. Log into your account.
3. Go to any posts.
4. Tap on the meatball menu (horizontal 3 dot menu).

Expected Behavior:
Settings options shown for that post.

Actual Behavior:
Does not work.

Notes:

• Reproduces regardless of the status of ETP
• Reproduces in Firefox Nightly
• Does not reproduce in Firefox Release, and Chrome

Created from https://github.com/webcompat/web-bugs/issues/141642

Comment 1

[Calin Tanase]

Attachment: Nightly vs Release.mp4

Comment 2

[Ryan VanderMeulen [:RyanVM]]

Does this reproduce in Beta?

Comment 3

[Calin Tanase]

Does not reproduce on FF Beta 131.0-20240916092141 .

Comment 4

[Greg Tatum [:gregtatum]]

No severity is set on this one yet, and it's about to ride out to Beta. Is this worth getting someone to take a look at? Seems like it may be an important one to fix or at least understand.

Firefox 132 | Regression Engineering Owner (REO)

Comment 5

[Ksenia Berezina [:ksenia] on leave until 09/15]

Looks like this is regressed by bug1917511. Hi emilio, wonder if you could take a look?

Was this integration build good, bad, or broken? (type 'good', 'bad', 'skip', 'retry', 'back' or 'exit' and press Enter): good
13:27.01 INFO: Narrowed integration regression window from [80df3fd7, 8312c557] (4 builds) to [227a47dd, 8312c557] (2 builds) (~1 steps left)
13:27.01 INFO: No more integration revisions, bisection finished.
13:27.01 INFO: Last good revision: 227a47dd111c05783ca64ea753faae14c5175c91
13:27.01 INFO: First bad revision: 8312c5570b7e993c323f0b47a42338b61b6daee2
13:27.01 INFO: Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=227a47dd111c05783ca64ea753faae14c5175c91&tochange=8312c5570b7e993c323f0b47a42338b61b6daee2

Comment 6

[Ksenia Berezina [:ksenia] on leave until 09/15]

FWIW I used a first post in a group, i.e. https://www.facebook.com/Originalhpfans/ to find regression range. This is also reproducible on RDM, but not on desktop.

This looks like a relevant chunk of code:

        if (Stc(k.parentNode) !== Stc(a.b)) {
          a.b.insertBefore(k, a.b.childNodes[e + 1]);
          d.dj()
        } else d.Pi() ? d.Wi() : d.kj()

Comment 7

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1919031 - Fix last child check. r=smaug

Ugh

Comment 9

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1919031 - Also check for out of bounds before populating the cache. r=smaug

I guess since facebook does this it is probably worth it.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d8b7f10eb81d
Fix last child check. r=smaug

Comment 11

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/48425 for changes under testing/web-platform/tests

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9caa349ee53a
Also check for out of bounds before populating the cache. r=smaug

Comment 13

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/d8b7f10eb81d
https://hg.mozilla.org/mozilla-central/rev/9caa349ee53a

Comment 14

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 15

[Ryan VanderMeulen [:RyanVM]]

Please nominate this for Beta approval when you get a chance.

Comment 16

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 9428474 [details]
Bug 1919031 - Fix last child check. r=smaug

Beta/Release Uplift Approval Request

• User impact if declined: correctness issue that affects facebook
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: comment 0
• List of other uplifts needed: none
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Trivial fix
• String changes made/needed: none
• Is Android affected?: Yes

Comment 17

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9428474 [details]
Bug 1919031 - Fix last child check. r=smaug

Approved for 132.0b5.

Comment 18

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/b45c52b2d1c7
https://hg.mozilla.org/releases/mozilla-beta/rev/d7ba123acedf

Comment 19

[Delia Pop (Android QA)]

Attachment: media_20241010_114706_5024219419246298973.mp4

This was verified as fixed in latest Nightly 133.0a1 from 10/10 and Beta 132.0b5 with Lenovo Yoga Tab 11 (Android 12), OPPO A15s (Android 10) and Google Pixel 8 Pro (Android 14).