1919040 - 162.8 - 42.85% perf_reftest_singletons svg-text-textLength-1.html / perf_reftest_singletons svg-text-textLength-1.html + 2 more (Linux, OSX, Windows) regression on Wed August 21 2024

Status: VERIFIED FIXED

(Core :: SVG, defect)

Description

[Treeherder Bug Filer]

Perfherder has detected a talos performance regression from push 246ed0e1a9345f7c55759d1a4e96cdfc89b8ba91. As author of one of the patches included in that push, we need your help to address this regression.

Regressions:

Ratio	Test	Platform	Options	Absolute values (old vs new)
163%	perf_reftest_singletons svg-text-textLength-1.html	linux1804-64-shippable-qr	e10s fission stylo webrender	1,318.22 -> 3,464.33
162%	perf_reftest_singletons svg-text-textLength-1.html	linux1804-64-shippable-qr	e10s fission stylo webrender	1,323.96 -> 3,473.75
64%	perf_reftest_singletons svg-text-textLength-1.html	macosx1015-64-shippable-qr	e10s fission stylo webrender	1,337.36 -> 2,194.33
43%	perf_reftest_singletons svg-text-textLength-1.html	windows11-64-shippable-qr	e10s fission stylo webrender	732.35 -> 1,046.13

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests. Please follow our guide to handling regression bugs and let us know your plans within 3 business days, or the patch(es) may be backed out in accordance with our regression policy.

If you need the profiling jobs you can trigger them yourself from treeherder job view or ask a sheriff to do that for you.

You can run these tests on try with ./mach try perf --alert 1804

For more information on performance sheriffing please see our FAQ.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 878346

Comment 2

[Jonathan Kew [:jfkthame]]

Though the regression here seems quite large, I'm going to call this S3 as it's limited to a relatively little-used (I think) SVG feature, so the impact shouldn't be at all widespread.

Comment 3

[Robert Longson [:longsonr]]

There's pretty much no SVG out there with 44K of text.

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1919040 - Allow choosing scales < 1.0 for SVG text. r=longsonr

This matches the previous behavior. The test in question has a
scale of 0.1 in the test, which changes our font choice and uses simpler
glyph advances.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/861f44128431
Allow choosing scales < 1.0 for SVG text. r=longsonr

Comment 6

[Sandor Molnar[:smolnar]]

Backed out for causing perma reftest failures

Backout link: https://hg.mozilla.org/integration/autoland/rev/51d34b0464a6aace42f298ba6fcd62105c13df59

Push with failures

Failure log

Comment 7

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1919040 - Fix some pre-existing transform invalidation issues. r=longsonr

When the transform attribute was removed from <g> we weren't notifying
of TRANSFORM_CHANGED.

Comment 8

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1919040 - Remove some unneeded transform attr invalidation. r=longsonr

Style invalidation should take care of it.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3e3d5755e474
Allow choosing scales < 1.0 for SVG text. r=longsonr
https://hg.mozilla.org/integration/autoland/rev/7efb5e983a8e
Fix some pre-existing transform invalidation issues. r=longsonr
https://hg.mozilla.org/integration/autoland/rev/1e9d3cc7b903
Remove some unneeded transform attr invalidation. r=longsonr
https://hg.mozilla.org/integration/autoland/rev/70f2552c0717
apply code formatting via Lando

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d6e2c8ac1184
Remove wpt file svgtransformlist-replaceitem.html.ini for passing on every platform. r=emilio CLOSED TREE

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/11b614cd24c1
Increase fuzz on a test now that we choose a slightly different scale due to invalidation fixes.

Comment 12

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/3e3d5755e474
https://hg.mozilla.org/mozilla-central/rev/7efb5e983a8e
https://hg.mozilla.org/mozilla-central/rev/1e9d3cc7b903
https://hg.mozilla.org/mozilla-central/rev/70f2552c0717
https://hg.mozilla.org/mozilla-central/rev/d6e2c8ac1184
https://hg.mozilla.org/mozilla-central/rev/11b614cd24c1

Comment 13

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:emilio, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox131 to wontfix.

For more information, please visit BugBot documentation.

Comment 14

[Emilio Cobos Álvarez (:emilio)]

Confirmed the graph went to pre-regression values.