1919061 - Fix mis-matched feature config name for configurable Bookmarks button surface

Status: VERIFIED FIXED

(Firefox :: Messaging System, defect, P1)

Description

[Hanna Alemu [:hanna_a]]

The feature config names are mismatched in https://searchfox.org/mozilla-central/source/toolkit/components/nimbus/FeatureManifest.yaml#3692 and https://searchfox.org/mozilla-central/source/browser/components/asrouter/modules/MessagingExperimentConstants.sys.mjs#41 resulting in ASRouter not fetching experiments on this feature.

Comment 1

[Hanna Alemu [:hanna_a]]

Attachment: Bug 1919061 - Fix mis-matched feature config name for configurable Bookmarks button surface

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c6ca01b323c6
Fix mis-matched feature config name for configurable Bookmarks button surface r=omc-reviewers,mviar

Comment 3

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/c6ca01b323c6

Comment 4

[Hanna Alemu [:hanna_a]]

Comment on attachment 9425034 [details]
Bug 1919061 - Fix mis-matched feature config name for configurable Bookmarks button surface

Beta/Release Uplift Approval Request

• User impact if declined: This change is needed to support a OMC experiment targeting Fx 131.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: * Enroll in treatment A of this experiment https://experimenter.services.mozilla.com/nimbus/bookmarks-bar-button-early-day/summary
• In about:asrouter, you should now see the message from the experiment, search for the ID BMB_BTN_EARLY_DAY
• In a new tab, you should also see the "Getting Started" button from the experiment in the bookmarks bar
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This is a naming change and doesn't add new functionality.
• String changes made/needed: No
• Is Android affected?: No

Comment 5

[Dianna Smith [:diannaS]]

Comment on attachment 9425034 [details]
Bug 1919061 - Fix mis-matched feature config name for configurable Bookmarks button surface

Approved for 131.0b8

Comment 6

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/287dd7c6ae49

Comment 7

[Marius Coman [:mcoman], Ecosystem QA]

I have verified that this issue is no longer reproducible using the latest Firefox Nightly 132.0a1 (Build ID: 20240918041351) and Firefox Beta 131.0b8 (Build ID: 20240917194455) downloaded from Treeherder installed on Windows 10 x64. I can confirm the following after enrolling in the Treatment A branch of the Bookmarks Bar Button Early Day experiment:

• The "Getting Started" button is displayed in the "Bookmarks" toolbar.
• The "BMB_BTN_EARLY_DAY" message is displayed in the "about:asrouter" page when filtering after the "messaging-experiments" provider.