1919122 - panel-item should support disabled attribute

Status: RESOLVED FIXED

(Toolkit :: UI Widgets, defect, P3)

Description

[Mark Striemer [:mstriemer]]

In bug 1918541 we noticed that the panel-item does not support the disabled attribute. This would help with any issues upgrading the component and would be more consistent with how elements are normally disabled

This snippet could be used as a starting point

--- a/toolkit/content/widgets/panel-list/panel-list.js
+++ b/toolkit/content/widgets/panel-list/panel-list.js
@@ -600,7 +600,7 @@
     #defaultSlot;
 
     static get observedAttributes() {
-      return ["accesskey", "type"];
+      return ["accesskey", "type", "disabled"];
     }
 
     constructor() {
@@ -742,7 +742,7 @@
         } else {
           this._accessKey = null;
         }
-      } else if (name === "type") {
+      } else if (name === "type" || name === "disabled") {
         this.#setButtonAttributes();
       }
     }
@@ -755,6 +755,7 @@
         this.button.setAttribute("role", "menuitem");
         this.button.removeAttribute("aria-checked");
       }
+      this.button.toggleAttribute("disabled", this.disabled);
     }
 
     #setLabelContents() {
@@ -772,11 +773,12 @@
     }
 
     get disabled() {
-      return this.button.hasAttribute("disabled");
+      return this.hasAttribute("disabled");
     }
 
     set disabled(val) {
-      this.button.toggleAttribute("disabled", val);
+      this.toggleAttribute("disabled", val);
+      this.#setButtonAttributes();
     }
 
     get checked() {

Comment 1

[akulyk]

Attachment: Bug 1919122 - panel-item should support disabled attribute r=#recomp-reviewers

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4ed604653424
panel-item should support disabled attribute r=reusable-components-reviewers,credential-management-reviewers,hjones,mtigley

Comment 3

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/4ed604653424