1919158 - Request urgency may ignore fetchPriority and supportsPriority in two scenarios

Status: RESOLVED FIXED

(Core :: Networking, defect, P3)

Description

[Andrew Creskey [:acreskey]]

We call nsHttpHandler::UrgencyFromCoSFlags(uint32_t cos, int32_t aSupportsPriority) to calculate the urgency for a request, using class of service and provided nsiSupportsPriority (which also reflects fetchPriority).

However in two scenarios we don't pass in the aSupportsPriority field, and so only calculate urgency from class of service:

Http2StreamBase::UpdatePriority

HTTP3Stream constructor

These may affect the urgency on PRIORITY_UPDATE frames?

Comment 1

[Andrew Creskey [:acreskey]]

This looks to be related to deprioritizing tabs as they are backgrounded/foregrounded.

Comment 2

[Valentin Gosu [:valentin] (he/him)]

Attachment: Bug 1919158 - Pass nsISupportsPriority to UrgencyFromCoSFlags r=acreskey

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a2a4a88ef8d1
Pass nsISupportsPriority to UrgencyFromCoSFlags r=acreskey,necko-reviewers,kershaw

Comment 4

[Atila Butkovits]

Backed out for causing bustages at ipc_message_utils.h.

Backout link: https://hg.mozilla.org/integration/autoland/rev/adf3c6ac684d94e7ecdf9b1d9645c49ee3c71a41

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&selectedTaskRun=GQ3MUnWvT0OJmZX4VXoKjA.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=a2a4a88ef8d1f628e8f1c23eb9c20ecf3708361f

Failure log: https://treeherder.mozilla.org/logviewer?job_id=475604221&repo=autoland&lineNumber=29918

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/82766c877c09
Pass nsISupportsPriority to UrgencyFromCoSFlags r=acreskey,necko-reviewers,kershaw

Comment 6

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/82766c877c09