1919220 - Downscaled image inside button makes it too wide

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[psychpsyo]

Attachment: Repro File

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:130.0) Gecko/20100101 Firefox/130.0

Steps to reproduce:

1. Put a 200x200px <img> into a <button>.
2. Give the button height: 50px and the img height: 100%.
3. Observe that the button is as wide as the original image, with gaps to either side of the image.

This is a regression, it happens on nightly for me (fresh build from source) and it does not happen on my regular Firefox 130 install.
I've tagged it as 132, I hope that is correct, just know that by 132 I mean 'Nightly, built from source'.

Actual results:

The button was 200px wide.

Expected results:

The button should be 50px wide.

Comment 1

[psychpsyo]

Attachment: Demonstration, top is 130, bottom is Nightly, built from source

Comment 2

[Francesco Lodolo [:flod]]

https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=f68eda3d65dd80db08c49ffabb424ac78bcc4332&tochange=d0336fee53a3e4eaee3e4db7c46245b9363084df

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1909761

:TYLin, since you are the author of the regressor, bug 1909761, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 4

[Jonathan Kew [:jfkthame]]

Seems like a significant regression that has the potential to cause real-world site breakages. Thanks for the prompt report, psychpsyo.

Comment 5

[psychpsyo]

I only found this because it caused real-world site breakage on one of my sites. (the buttons in the top right corner on https://battle.crossuniverse.net/deckMaker/index.html are affected by this, meaning they're spaced apart more than they should be)

Comment 6

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

Attachment: Bug 1919220 - Pass percentage basis when computing intrinsic contribution for button control's inner frame. r?#layout

Comment 7

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

The reduced testcase is really helpful for me to identify the problem. Thanks!

Comment 8

[Jonathan Kew [:jfkthame]]

Attachment: Bug 1919220 - patch 2 - Also pass percentage basis when computing intrinsic contribution for fieldset contents. r?#layout

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/98ea87fd51e1
Pass percentage basis when computing intrinsic contribution for button control's inner frame. r=layout-reviewers,jfkthame
https://hg.mozilla.org/integration/autoland/rev/b51d80a6a0c4
patch 2 - Also pass percentage basis when computing intrinsic contribution for fieldset contents. r=dshin

Comment 10

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/98ea87fd51e1
https://hg.mozilla.org/mozilla-central/rev/b51d80a6a0c4

Comment 11

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/48279 for changes under testing/web-platform/tests

Comment 12

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot