1919223 - Show sidebars is not moved back to its default place when restoring defaults in Customize Toolbar

Status: NEW

(Firefox :: Sidebar, defect, P2)

Description

[Catalin Sasca, Desktop Test Engineering [:csasca]]

Found in

• Nightly 132.0a1

Affected versions

• Nightly 132.0a1 (2024-09-16)

Affected platforms

• All

Preconditions

• Set the following prefs:
  sidebar.revamp - true

Steps to reproduce

1. Remove "Show sidebars" button from the toolbar
2. Access Customize Toolbar and click on Restore Defaults

Expected result

• The button is moved back on its default place

Actual result

• The button is still in the Customize toolbar list

Regression range

• Not a regression

Additional Notes

• See the issue in the following attachment.

Comment 1

[Stuart Colville [:muffinresearch]]

Hi, testing this STR on MacOS, Windows and Linux and I don't seem to be able to reproduce it. The "show sidebars" icon is restored as expected. Can you check if there's something else needed in the STR to trigger it?

Comment 2

[Catalin Sasca, Desktop Test Engineering [:csasca]]

Yep, didn't reproduce on Windows, but was able do reproduce it on macOS, it seems that it is kind of intermittent. Maybe trying with new profiles each time will help reproduce it.

Comment 3

[Stuart Colville [:muffinresearch]]

Further testing with new profile on Mac definitely made this easier to reproduce. However, as soon as you close and reopen the browser it doesn't seem to be possible to reproduce these issues.

Other observations and additional issues (I'm adding them here, but we can also file additional bugs if needed if they're things that would be better to handle independently).

• When removing the sidebar button from the toolbar (right-click and select "Remove from toolbar")
  • When you then open the customize toolbar menu the icon has no text underneath it. (Sometimes it does but it seems to not have it if it's the only item customized).
• When the defaults are restored and the sidebar icon stays in the customize menu (as described in this bug's STR), "Restore defaults is greyed out" this suggest it's not seen as a default to have it placed back on the toolbar. (Easier to see from a new profile as well because you'll be starting with no customizations).

As with the original issue, this is appears to be only reproducible with a fresh profile and after being able to repro it seems to disappear after a restart.

Comment 4

[Sarah Clements [:sclements]]

Is there still issues with this? Wondering if we should close this out.

Comment 5

[Catalin Sasca, Desktop Test Engineering [:csasca]]

Yep, I can still reproduce this on 133.0b8, macOS 15.1.