1919241 - WASI recursion limit functions probably shouldn't be marked MOZ_COLD

Status: NEW

(Core :: JavaScript Engine, task, P2)

Description

[Jan de Mooij [:jandem]]

Julian was looking into behavior of lazy tiering on the WASI demo and some of these functions showed up as hot enough to be tiered up: CheckWasiRecursionLimit, IncWasiRecursionDepth, etc.

They're marked MOZ_COLD and that's probably why LLVM isn't inlining them.

Comment 1

[Jan de Mooij [:jandem]]

Was there a reason for marking these MOZ_COLD in this change? IIUC these checks used to be always-inline.

Comment 2

[Tooru Fujisawa [:arai]]

I don't remember the reason, and it looks most likely a copy-paste artifact from ReportOverRecursed below, or something along that line.

anyway, I don't see any reason the cannot be inlined, and the MOZ_COLD annotation can be removed.