1919301 - The context menu from several sub-dialogs from Preferences displays a lot of unnecessary options

Status: VERIFIED FIXED

(Firefox :: Settings UI, defect)

Description

[Camelia Badau [:cbadau], Desktop Test Engineering]

Attachment: issue.png

Found in

• Firefox 131.0b7

Affected versions

• Nightly 132.0a1 (2024-09-16)
• Firefox 131.0b7
• Firefox 130.0.1

Tested platforms

• Affected platforms: Windows 11, Windows 10, macOS 12, Ubuntu 24.04
• Unaffected platforms: none

Steps to reproduce

1. Go to about:preferences#privacy
2. Click on the "Manage Exceptions..." button from Enhanced Tracking Protection.
3. Right click on "Address of website" and observe the options from the context menu.

Expected result
The following specific options are displayed in the context menu: Undo, Redo, Cut, Copy, Paste, Delete, Select All, This Frame, Check Spelling, Inspect.

Actual result
A lot of unnecessary options are displayed in the context menu. Please see attachment "issue.png".

Regression range

• I will provide one as soon as possible. For the reference, Firefox 129.0.2 is not affected.

Additional notes

• The issue is also reproducible on the following sub-dialogs from about:preferences#privacy:
  • "Cookies and Site Data" -> "Manage Data" and "Manage Exeptions..." sub-dialogs
  • "Passwords" -> "Exceptions..." sub-dialog

Comment 1

[Alice0775 White]

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=ad57df08b5385f1b5d44c77f14231c3d5108832c&tochange=6a254993ba42e4cee3cdf1548effc51f30d574e4

Browser console shows the following error:

Uncaught TypeError: can't access property "defaultView", this.ownerDoc is undefined
    setContext chrome://browser/content/nsContextMenu.sys.mjs:268
    nsContextMenu chrome://browser/content/nsContextMenu.sys.mjs:99
    <anonymous> chrome://browser/content/browser-context.js:304
nsContextMenu.sys.mjs:268:7
    setContext chrome://browser/content/nsContextMenu.sys.mjs:268
    nsContextMenu chrome://browser/content/nsContextMenu.sys.mjs:99
    <anonymous> chrome://browser/content/browser-context.js:304

Error: createFromDocumentRoot: aDocumentRoot must be an HTMLHtmlElement FormLikeFactory.sys.mjs:55:13

Uncaught TypeError: can't access property "hiding", gContextMenu is null
    <anonymous> chrome://browser/content/browser-context.js:319
browser-context.js:319:7
    <anonymous> chrome://browser/content/browser-context.js:319

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1900009

:rsafaeian, since you are the author of the regressor, bug 1900009, could you take a look?

For more information, please visit BugBot documentation.

Comment 3

[Ryan Safaeian [:rsafaeian]]

Attachment: Bug 1919301 - Throw error in createFromDocumentRoot only when aDocumentRoot is null. r=#credential-management-reviewers

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/08b2387f2f1c
Throw error in createFromDocumentRoot only when aDocumentRoot is null. r=credential-management-reviewers,issammani

Comment 5

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/08b2387f2f1c

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Please nominate this for Beta uplift also.

Comment 7

[Ryan Safaeian [:rsafaeian]]

Attachment: Bug 1919301 - Throw error in createFromDocumentRoot only when aDocumentRoot is null. r=#credential-management-reviewers

For HTML documents, createFromDocumentRoot would normally never throw an error, since the root element for an HTML document is always HTMLHtmlElement, however, for any non-empty XML document, the root element is not any specific type. This caused createFromDocumentRoot to throw an error in the context menu.

Original Revision: https://phabricator.services.mozilla.com/D222621

Comment 8

[Phabricator Automation]

beta Uplift Approval Request

• User impact if declined: Cluttered context menu when clicking on input
• Code covered by automated testing: no
• Fix verified in Nightly: yes
• Needs manual QE test: yes
• Steps to reproduce for manual QE testing: Steps are outlined in the bug description since QA found the bug.
• Risk associated with taking this patch: None
• Explanation of risk level: N/A
• String changes made/needed: No
• Is Android affected?: no

Comment 9

[Dianna Smith [:diannaS]]

[:rsafaeian] the beta patch does not apply cleanly. Please fix conflicts on toolkit/modules/FormLikeFactory.sys.mj on a rebased patch

Comment 10

[Camelia Badau [:cbadau], Desktop Test Engineering]

Verified fixed on Windows 10, Windows 11, macOS 13 and Ubuntu 22 using latest Nightly 132.0a1 (buildID: 20240920090503).

Comment 11

[Ryan Safaeian [:rsafaeian]]

I rebased the patch. It should be good now.

Comment 12

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/4918c42301d7

Comment 13

[Camelia Badau [:cbadau], Desktop Test Engineering]

Verified fixed on Windows 10, Windows 11, macOS 13 and Ubuntu 22 using Firefox 131 Beta build from Treeherder.